Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2240663004: Dump information when we hit a FATAL in become (Closed)

Created:
4 years, 4 months ago by Cutch
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -1 line) Patch
M runtime/vm/become.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/become.cc View 2 chunks +33 lines, -1 line 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 4 months ago (2016-08-12 14:18:51 UTC) #3
rmacnak
lgtm Maybe also check earlier in AddBecomeMapping.
4 years, 4 months ago (2016-08-12 16:44:39 UTC) #4
Cutch
4 years, 4 months ago (2016-08-12 20:48:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3aba8355f366306a4b19b2e639cc7d1b7f389e2b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698