Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Ultimately, avoids wasteful redundant computation and storage of distance
field fake-gamma tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240623002

Committed: https://skia.googlesource.com/skia/+/86e7626f080028edd58f4b326e0ba9fa83c4208e

[Brian Osman, 2016-08-11 18:23:54]

Description was changed from

==========
Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Ultimately, avoids wasteful redundant computation and storage of distance
field fake-gamma tables.

BUG=skia:
==========

to

==========
Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Ultimately, avoids wasteful redundant computation and storage of distance
field fake-gamma tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240623002
==========

[Brian Osman, 2016-08-11 18:25:18]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 18:25:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Brian Osman, 2016-08-11 18:25:45]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com, msarett@google.com,
robertphillips@google.com

[robertphillips, 2016-08-11 18:33:09]

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h#...
src/gpu/GrDrawingManager.h:10: 
Can we predeclare this rather than include it?

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h#...
src/gpu/GrDrawingManager.h:86: 
might as well sk_sp this

[bsalomon, 2016-08-11 18:33:45]

lgtm w/ nit

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h#...
src/gpu/GrDrawingManager.h:87: SkAutoTDelete<GrAtlasTextContext>
fAtlasTextContext;
preserve alignment (or unalign everyone)?

[bsalomon, 2016-08-11 18:34:44]

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h#...
src/gpu/GrDrawingManager.h:86: 
On 2016/08/11 18:33:08, robertphillips wrote:
> might as well sk_sp this

It's not ref-counted.

[Brian Osman, 2016-08-11 18:37:14]

Fixed alignment

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h
File src/gpu/GrDrawingManager.h (right):

https://codereview.chromium.org/2240623002/diff/1/src/gpu/GrDrawingManager.h#...
src/gpu/GrDrawingManager.h:10: 
On 2016/08/11 18:33:08, robertphillips wrote:
> Can we predeclare this rather than include it?

No, because of the smart pointer destructor. :(

[Brian Osman, 2016-08-11 18:38:24]

The CQ bit was checked by brianosman@google.com

[Brian Osman, 2016-08-11 18:38:24]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2240623002/#ps20001
(title: "Fix alignment")

[commit-bot: I haz the power, 2016-08-11 18:38:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-11 18:52:12]

lgtm

[commit-bot: I haz the power, 2016-08-11 19:17:35]

Description was changed from

==========
Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Ultimately, avoids wasteful redundant computation and storage of distance
field fake-gamma tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240623002
==========

to

==========
Move GrAtlasTextContext to GrDrawingManager, so we only have one.

Ultimately, avoids wasteful redundant computation and storage of distance
field fake-gamma tables.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240623002

Committed:
https://skia.googlesource.com/skia/+/86e7626f080028edd58f4b326e0ba9fa83c4208e
==========

[commit-bot: I haz the power, 2016-08-11 19:17:36]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/86e7626f080028edd58f4b326e0ba9fa83c4208e

[jvanverth1, 2016-08-11 19:39:46]

https://codereview.chromium.org/2240623002/diff/20001/src/gpu/GrDrawingManage...
File src/gpu/GrDrawingManager.cpp (right):

https://codereview.chromium.org/2240623002/diff/20001/src/gpu/GrDrawingManage...
src/gpu/GrDrawingManager.cpp:154: if (!fAtlasTextContext) {
Sorry I'm late to the party. Is there any problem with just creating this in the
constructor for GrDrawingManager? It would avoid a conditional every time we
draw text.