Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2240603004: Fix the bug that occurs when use a customized ndk. (Closed)

Created:
4 years, 4 months ago by hanpfei
Modified:
4 years, 4 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the bug that occurs when use a customized ndk. Refs the sources/android/cpufeatures/cpu-features.c file in the ndk root, but not the fixed third_party/android_tools/ndk/. BUG=637218 Signed-off-by: Pengfei Han <hanpfei@gmail.com>;

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/secondary/third_party/android_tools/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240603004/1
4 years, 4 months ago (2016-08-12 08:49:31 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-12 08:49:32 UTC) #5
agrieve
4 years, 4 months ago (2016-08-22 20:28:59 UTC) #7
On 2016/08/12 08:49:32, commit-bot: I haz the power wrote:
> No L-G-T-M from a valid reviewer yet. 
> CQ run can only be started by full committers or once the patch has
> received an L-G-T-M from a full committer.
> Even if an L-G-T-M may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Hmm, this came to me twice. The other is
https://codereview.chromium.org/2257933004/. Arbitrarily chose the other one to
l-g-t-m.

Powered by Google App Engine
This is Rietveld 408576698