Harmony checkbox/radio tweaks

ui/native_theme/common_theme.cc

Index: ui/native_theme/common_theme.cc
diff --git a/ui/native_theme/common_theme.cc b/ui/native_theme/common_theme.cc
index edf361f0334f0800e3784e7bda46ac95ba8d14cd..07e756beedd0ba1da67551050266b4c5478afe3e 100644
--- a/ui/native_theme/common_theme.cc
+++ b/ui/native_theme/common_theme.cc
@@ -58,6 +58,7 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
         return kMenuHighlightBackgroundColorMd;
       case NativeTheme::kColorId_SelectedMenuItemForegroundColor:
         return kSelectedMenuItemForegroundColorMd;
+
       // Link
       case NativeTheme::kColorId_LinkEnabled:
       case NativeTheme::kColorId_LinkPressed:
@@ -103,6 +104,14 @@ SkColor GetAuraColor(NativeTheme::ColorId color_id,
     }
   }
 
+  // Second wave of MD colors (colors that only appear in secondary UI).
+  if (ui::MaterialDesignController::IsSecondaryUiMaterial()) {
+    static const SkColor kPrimaryTextColor = SkColorSetRGB(0x33, 0x33, 0x33);

[sky, 2016/08/13 16:03:32]

optional: Is there a reason you want this here, and not inside the conditional
where it is used? I would be tempted to combine the if statement into a single
one with the static inside it, but perhaps you have it like this because you
foresee more differences?

[Evan Stade, 2016/08/14 01:49:21]

I was following the convention in the rest of the file, where a bunch of color
constants are defined and then a switch below (or in this case, for now, a
conditional) uses the constants. I suspect more than one kColorId thing will
want kPrimaryTextColor because it's part of a three-tone palette that bettes@
came up with.
Indeed, I was assuming there would be more secondary-ui related color changes.
I'm not sure that will actually happen but it seems likely.

+
+    if (color_id == NativeTheme::kColorId_LabelEnabledColor)
+      return kPrimaryTextColor;
+  }
+
   // Pre-MD colors.
   // Windows:
   static const SkColor kWindowBackgroundColor = SK_ColorWHITE;