Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 2240593002: Compute the linked bundle for the SDK extension. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute the linked bundle for the SDK extension. As Brian noticed, we have at most one extension, it would be waste to implement general multi-extension linking. So, for now we have support only for one. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bd1c47146eb01cb28c02f61a5d1ae34d6157d236

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/pub_summary.dart View 3 chunks +91 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/pub_summary_test.dart View 1 chunk +113 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 4 months ago (2016-08-11 17:21:31 UTC) #1
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-08-11 17:59:28 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as bd1c47146eb01cb28c02f61a5d1ae34d6157d236 (presubmit successful).
4 years, 4 months ago (2016-08-11 18:21:11 UTC) #4
Paul Berry
4 years, 4 months ago (2016-08-11 18:25:11 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698