Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2240573004:
Fail builds when lint warnings are generated. (Closed)
|
Created:
4 years, 4 months ago by estevenson Modified:
4 years, 4 months ago Reviewers:
agrieve CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFail builds when lint warnings are generated.
Suppress all existing lint warnings so that builds will fail when new
warnings are generated. New lint warnings that are generated in files
that are ignored in suppressions.xml will not be caught. However, now
we can remove lint warnings on a file by file basis instead of having to
fix all lint warnings before making lint break builds.
BUG=607761
Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe
Committed: https://crrev.com/9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce
Cr-Original-Commit-Position: refs/heads/master@{#411692}
Cr-Commit-Position: refs/heads/master@{#411748}
Patch Set 1 #Patch Set 2 : Add suppressions for cast_shell_apk and change all suppressions to use regex except for paths that … #Patch Set 3 : rebase + suppress new lint warnings #
Messages
Total messages: 30 (17 generated)
ptal Andrew. This CL allows you to build all targets with no lint warnings generated, however, I'm worried about all of the existing lint warnings being forgotten about. I can look after all of the warnings generated when building chrome_public_apk but there are several other targets that have warnings suppressed as well. Is this a concern?
estevenson@chromium.org changed reviewers: + agrieve@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
On 2016/08/12 01:01:26, agrieve wrote: > lgtm Note: you can repro the chromecast error locally by mirroring the GN args shown in its "Generate Build Files" step. Namely, add is_chromecast = true.
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by estevenson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2240573004/#ps20001 (title: "Add suppressions for cast_shell_apk and change all suppressions to use regex except for paths that …")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 ========== to ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2245663003/ by xidachen@chromium.org. The reason for reverting is: Causing compilation failure: https://build.chromium.org/p/chromium.linux/builders/Android%20Builder/builds....
Message was sent while issue was closed.
Description was changed from ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ========== to ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ==========
The CQ bit was checked by estevenson@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2240573004/#ps40001 (title: "rebase + suppress new lint warnings")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ========== to ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Cr-Commit-Position: refs/heads/master@{#411692} ========== to ========== Fail builds when lint warnings are generated. Suppress all existing lint warnings so that builds will fail when new warnings are generated. New lint warnings that are generated in files that are ignored in suppressions.xml will not be caught. However, now we can remove lint warnings on a file by file basis instead of having to fix all lint warnings before making lint break builds. BUG=607761 Committed: https://crrev.com/49f5130f956057407d2219e37a978437bcdcf7fe Committed: https://crrev.com/9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce Cr-Original-Commit-Position: refs/heads/master@{#411692} Cr-Commit-Position: refs/heads/master@{#411748} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9a52a7e12ad50f6f85e88c6a5636ce6e0a405dce Cr-Commit-Position: refs/heads/master@{#411748}
Message was sent while issue was closed.
This broke build again: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builde...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2236313004/ by caseq@chromium.org. The reason for reverting is: Broke Android Arm64 builder.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
