Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc

Issue 2240553003: Track text selection on the browser side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added #ifdef Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
diff --git a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
index 8950f6056b3ee81d32bb519614442893a0688a86..81428e2671d0901a0dc7207b100391924663ff51 100644
--- a/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
+++ b/chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc
@@ -642,13 +642,13 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
for (auto* view : views)
send_tab_insert_text_wait_for_bounds_change(view);
}
+#endif
// This test creates a page with multiple child frames and adds an <input> to
// each frame. Then, sequentially, each <input> is focused by sending a tab key.
// After focusing each input, a sequence of key presses (character 'E') are sent
-// to the focused widget and then the whole text is selected using Ctrl+A. The
-// test then verifies that the selection length equals the length of the
-// sequence of 'E's.
+// to the focused widget. The test then verifies that the selection length
+// equals the length of the sequence of 'E's.
IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
TrackTextSelectionForAllFrames) {
CreateIframePage("a(b,c(a,b),d)");
@@ -680,9 +680,6 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
ui::DomCode::US_E, ui::VKEY_E, false, false, false,
false);
}
- // Send Ctrl+A to select the whole text.
- SimulateKeyPress(web_contents, ui::DomKey::FromCharacter('a'),
- ui::DomCode::US_A, ui::VKEY_A, true, false, false, false);
observer.Wait();
};
@@ -697,6 +694,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
}
}
+#if defined(USE_AURA)
// The following test verifies that when the active widget changes value, it is
// always from nullptr to non-null or vice versa.
IN_PROC_BROWSER_TEST_F(SitePerProcessTextInputManagerTest,
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698