content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 2240553003: Track text selection on the browser side (Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 2240553003: Track text selection on the browser side (Mac) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: GetFocusedWidget() instead of GetFocusedSubView() Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.mm ('k') | content/browser/renderer_host/text_input_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index b4eecea318e93a82317a96f56240090d31a7d047..412ad770f1cef4002c3fdafe8852c8a724dbe781 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -254,6 +254,8 @@ class RenderWidgetHostViewMacTest : public RenderViewHostImplTestHarness {

// Owned by its |cocoa_view()|, i.e. |rwhv_cocoa_|.

rwhv_mac_ = new RenderWidgetHostViewMac(rvh()->GetWidget(), false);

+ RenderWidgetHostImpl::From(rvh()->GetWidget())->SetView(rwhv_mac_);

rwhv_cocoa_.reset([rwhv_mac_->cocoa_view() retain]);

}

void TearDown() override {