Track text selection on the browser side (Mac)

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <set>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 2731 matching lines @@
   selection_controller_->OnSelectionEmpty(is_empty_text_form_control);
   selection_controller_->OnSelectionBoundsChanged(start, end);
 }
 
 void RenderWidgetHostViewAura::CreateSelectionController() {
   ui::TouchSelectionController::Config tsc_config;
   tsc_config.max_tap_duration = base::TimeDelta::FromMilliseconds(
       ui::GestureConfiguration::GetInstance()->long_press_time_in_ms());
   tsc_config.tap_slop = ui::GestureConfiguration::GetInstance()
                             ->max_touch_move_in_pixels_for_click();
   tsc_config.show_on_tap_for_empty_editable = false;

[EhsanK, 2016/08/17 06:22:33]

Sorry about the rebase + change together.

   tsc_config.enable_longpress_drag_selection = false;
   selection_controller_.reset(new ui::TouchSelectionController(
       selection_controller_client_.get(), tsc_config));
 }
 
 void RenderWidgetHostViewAura::HandleGestureForTouchSelection(
     ui::GestureEvent* event) {
   switch (event->type()) {
     case ui::ET_GESTURE_LONG_PRESS:
       if (selection_controller_->WillHandleLongPressEvent(
@@ skipping 251 matching lines @@
     GetInputMethod()->OnCaretBoundsChanged(this);
 }
 
 void RenderWidgetHostViewAura::OnTextSelectionChanged(
     TextInputManager* text_input_manager,
     RenderWidgetHostViewBase* updated_view) {
 #if defined(USE_X11) && !defined(OS_CHROMEOS)
   if (!GetTextInputManager())
     return;
 
-  const TextInputManager::TextSelection* text_selection = nullptr;
-  if (is_guest_view_hack_) {
-    // We obtain the TextSelection from focused RWH which is obtained from the
-    // frame tree. BrowserPlugin-based guests' RWH is not part of the frame tree
-    // and the focused RWH will be that of the embedder which is incorrect. In
-    // this case we should use TextSelection for |this| since RWHV for guest
-    // forwards text selection information to its platform view.
-    text_selection = GetTextInputManager()->GetTextSelection(this);
-  } else {
-    RenderWidgetHostImpl* focused_widget =
-        host_->delegate()->GetFocusedRenderWidgetHost(host_);
-    if (!!focused_widget && !!focused_widget->GetView()) {
-      text_selection = GetTextInputManager()->GetTextSelection(
-          focused_widget->GetView());
-    }
-  }
+  // We obtain the TextSelection from focused RWH which is obtained from the
+  // frame tree. BrowserPlugin-based guests' RWH is not part of the frame tree
+  // and the focused RWH will be that of the embedder which is incorrect. In
+  // this case we should use TextSelection for |this| since RWHV for guest
+  // forwards text selection information to its platform view.
+  RenderWidgetHostViewBase* focused_view =
+      is_guest_view_hack_ ? this : GetFocusedSubView(this);
 
-  if (!text_selection)
+  if (!focused_view)
     return;
 
-  if (text_selection->text.empty() || text_selection->range.is_empty())
-    return;
-  size_t pos = text_selection->range.GetMin() - text_selection->offset;
-  size_t n = text_selection->range.length();
-
-  DCHECK(pos + n <= text_selection->text.length())
-      << "The text can not fully cover range.";
-  if (pos >= text_selection->text.length()) {
-    NOTREACHED() << "The text can not cover range.";
-    return;
+  base::string16 selected_text;
+  if (GetTextInputManager()
+          ->GetTextSelection(focused_view)
+          ->GetSelectedText(&selected_text)) {
+    // Set the CLIPBOARD_TYPE_SELECTION to the ui::Clipboard.
+    ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_SELECTION);
+    clipboard_writer.WriteText(selected_text);
   }
-
-  // Set the CLIPBOARD_TYPE_SELECTION to the ui::Clipboard.
-  ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_SELECTION);
-  clipboard_writer.WriteText(text_selection->text.substr(pos, n));
 #endif  // defined(USE_X11) && !defined(OS_CHROMEOS)
 }
 
 }  // namespace content