test/cctest/test-parsing.cc - Issue 2240513003: Scanner::LiteralBuffer usage cleanup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-parsing.cc

Issue 2240513003: Scanner::LiteralBuffer usage cleanup. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Feedback fix compiler issues. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-parsing.cc

diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc

index b5e544fb3b3fe5a4b9814aa21cd47167d44ec9b3..e164d120a64fb2b051c43cd34d350d8d006cc2f4 100644

--- a/test/cctest/test-parsing.cc

+++ b/test/cctest/test-parsing.cc

@@ -885,7 +885,7 @@ void TestScanRegExp(const char* re_source, const char* expected) {

i::Token::Value start = scanner.peek();

CHECK(start == i::Token::DIV || start == i::Token::ASSIGN_DIV);

- CHECK(scanner.ScanRegExpPattern(start == i::Token::ASSIGN_DIV));

+ CHECK(scanner.ScanRegExpPattern());

scanner.Next(); // Current token is now the regexp literal.

i::Zone zone(CcTest::i_isolate()->allocator());

i::AstValueFactory ast_value_factory(&zone,

« no previous file with comments | « src/parsing/token.cc ('k') | no next file » | no next file with comments »