Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22405003: Revert "[css3-text] Implement text-decoration property shorthand" (Closed)

Created:
7 years, 4 months ago by falken
Modified:
7 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, darktears, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Revert "[css3-text] Implement text-decoration property shorthand" Reverting 155719 due to an assertion failure when starting content_shell: ASSERTION FAILED: Shorthand property id = 151 wasn't expanded at parsing time !isExpandedShorthand(id) ../../third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp(1152) : static void WebCore::StyleBuilder::applyProperty(WebCore::CSSPropertyID, WebCore::StyleResolverState&, WebCore::CSSValue*) This reverts commit aa0345dd4094dbc0483ac9e40c4608fdb887f3ce. BUG=165462 TBR=abinader Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -435 lines) Patch
M LayoutTests/editing/deleting/delete-line-break-before-underlined-content-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/deleting-line-break-preserves-underline-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-div-from-span-with-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-paragraph-from-span-with-multiple-text-decoration-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/deleting/merge-paragraph-from-span-with-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/inline-style-after-indentoutdent-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/remove-format-multiple-elements-mac-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/inline-style-after-indentoutdent.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements-mac.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/script-tests/toggle-style-2.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/execCommand/script-tests/toggle-text-decorations.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/execCommand/toggle-style-2-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/execCommand/toggle-text-decorations-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/execCommand/use-css.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/execCommand/use-css-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/insert-u-with-text-decoration-none-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/pasteboard/preserve-underline-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/inline-style-container-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-around-list-mac-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-around-list-win-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/push-down-implicit-styles-mac-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/push-down-inline-styles-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/editing/style/script-tests/inline-style-container.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list-mac.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list-win.js View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-implicit-styles-mac.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/editing/style/script-tests/push-down-inline-styles.js View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt View 1 chunk +57 lines, -39 lines 0 comments Download
M LayoutTests/fast/css/getComputedStyle/script-tests/getComputedStyle-text-decoration.js View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-1.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-3.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-3-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-4.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-4-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-5.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-alternate-stylesheet-5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-disabled-attr.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/css/link-disabled-attr-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties.html View 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/fast/css/style-enumerate-properties-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
D LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand.html View 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-expected.txt View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-ordering.html View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-shorthand-ordering-expected.txt View 1 chunk +0 lines, -39 lines 0 comments Download
M LayoutTests/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-line.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/media/w3c/test_media_queries.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/styles/styles-computed-trace-expected.txt View 2 chunks +2 lines, -14 lines 0 comments Download
M LayoutTests/inspector/styles/styles-new-API-expected.txt View 3 chunks +0 lines, -9 lines 0 comments Download
M LayoutTests/media/track/track-css-matching-default.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/track/track-css-matching-default-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSParser-in.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M Source/core/css/CSSShorthands.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 10 chunks +17 lines, -40 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
falken
7 years, 4 months ago (2013-08-08 09:18:09 UTC) #1
falken
7 years, 4 months ago (2013-08-08 09:20:32 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r155756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698