Give MainThreadEventQueue a mutable WebInputEvent.

Give MainThreadEventQueue a mutable WebInputEvent.

This paves the way for letting the InputEventFilter modify the
WebInputEvent's dispatchType, which is required for the
main thread responsiveness intervention (see the bug for details).

BUG=599609
TEST=Existing InputEventFilter/MainThreadEventQueue tests.

Committed: https://crrev.com/30d284dae5691a8d693409877b25afaba4629461
Cr-Commit-Position: refs/heads/master@{#411681}

[tdresser, 2016-08-11 14:55:47]

tdresser@chromium.org changed reviewers:
+ dtapuska@chromium.org

[tdresser, 2016-08-11 15:27:54]

Ready for review.

[tdresser, 2016-08-11 15:27:59]

The CQ bit was checked by tdresser@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 15:28:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-08-11 15:38:44]

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
File content/renderer/input/input_event_filter.cc (left):

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
content/renderer/input/input_event_filter.cc:209: }
I'd like to see a event->reset() here because the std::move is inside a branch.
It will prevent future bugs if someone uses event once it has been released.

[tdresser, 2016-08-11 18:55:48]

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
File content/renderer/input/input_event_filter.cc (left):

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
content/renderer/input/input_event_filter.cc:209: }
On 2016/08/11 15:38:43, dtapuska wrote:
> I'd like to see a event->reset() here because the std::move is inside a
branch.
> It will prevent future bugs if someone uses event once it has been released.

Good call, thanks.

[tdresser, 2016-08-12 12:33:26]

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
File content/renderer/input/input_event_filter.cc (left):

https://codereview.chromium.org/2240473002/diff/1/content/renderer/input/inpu...
content/renderer/input/input_event_filter.cc:209: }
On 2016/08/11 18:55:48, tdresser wrote:
> On 2016/08/11 15:38:43, dtapuska wrote:
> > I'd like to see a event->reset() here because the std::move is inside a
> branch.
> > It will prevent future bugs if someone uses event once it has been released.
> 
> Good call, thanks.

Done.

[dtapuska, 2016-08-12 13:29:29]

lgtm % the signatures.

https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
content/common/input/event_with_latency_info.h:40:
ScopedWebInputEventWithLatencyInfo(const ScopedWebInputEvent,
Why does this signature differ from the implementation signature?

https://codereview.chromium.org/2240473002/diff/40001/content/renderer/input/...
File content/renderer/input/main_thread_event_queue.h (right):

https://codereview.chromium.org/2240473002/diff/40001/content/renderer/input/...
content/renderer/input/main_thread_event_queue.h:22: EventWithDispatchType(const
ScopedWebInputEvent event,
Same the signature differs from is implementation signature. Perhaps I don't
understand something but I'd expect them to be the same.

[tdresser, 2016-08-12 16:31:54]

https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
File content/common/input/event_with_latency_info.h (right):

https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
content/common/input/event_with_latency_info.h:40:
ScopedWebInputEventWithLatencyInfo(const ScopedWebInputEvent,
On 2016/08/12 13:29:29, dtapuska wrote:
> Why does this signature differ from the implementation signature?

Whoops.
Done.

[tdresser, 2016-08-12 16:32:27]

The CQ bit was checked by tdresser@chromium.org

[tdresser, 2016-08-12 16:32:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtapuska@chromium.org
Link to the patchset: https://codereview.chromium.org/2240473002/#ps60001
(title: "Fixed consts")

[commit-bot: I haz the power, 2016-08-12 16:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtapuska, 2016-08-12 16:32:59]

On 2016/08/12 16:31:54, tdresser wrote:
>
https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
> File content/common/input/event_with_latency_info.h (right):
> 
>
https://codereview.chromium.org/2240473002/diff/40001/content/common/input/ev...
> content/common/input/event_with_latency_info.h:40:
> ScopedWebInputEventWithLatencyInfo(const ScopedWebInputEvent,
> On 2016/08/12 13:29:29, dtapuska wrote:
> > Why does this signature differ from the implementation signature?
> 
> Whoops.
> Done.

lgtm

[commit-bot: I haz the power, 2016-08-12 17:10:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 17:14:22]

Description was changed from

==========
Give MainThreadEventQueue a mutable WebInputEvent.

This paves the way for letting the InputEventFilter modify the
WebInputEvent's dispatchType, which is required for the
main thread responsiveness intervention (see the bug for details).

BUG=599609
TEST=Existing InputEventFilter/MainThreadEventQueue tests.
==========

to

==========
Give MainThreadEventQueue a mutable WebInputEvent.

This paves the way for letting the InputEventFilter modify the
WebInputEvent's dispatchType, which is required for the
main thread responsiveness intervention (see the bug for details).

BUG=599609
TEST=Existing InputEventFilter/MainThreadEventQueue tests.

Committed: https://crrev.com/30d284dae5691a8d693409877b25afaba4629461
Cr-Commit-Position: refs/heads/master@{#411681}
==========

[commit-bot: I haz the power, 2016-08-12 17:14:24]

Patchset 4 (id:??) landed as
https://crrev.com/30d284dae5691a8d693409877b25afaba4629461
Cr-Commit-Position: refs/heads/master@{#411681}