Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 2240443002: Revert of Switching from keepnames to keepclassmembernames for Parcelable (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
pkotwicz, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Switching from keepnames to keepclassmembernames for Parcelable (patchset #1 id:1 of https://codereview.chromium.org/2234463002/ ) Reason for revert: Crashes on startup https://bugs.chromium.org/p/chromium/issues/detail?id=636685 Original issue's description: > Switching from keepnames to keepclassmembernames for Parcelable > > This does not add/remove any classes, methods, or fields. > > It saves us 25kb in .dex size. > > BUG=619937 > > Committed: https://crrev.com/a7f9943a146ddc60427da3d4b74bf9bcbbcfb51f > Cr-Commit-Position: refs/heads/master@{#411034} TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=619937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/proguard.flags View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
smaier
Created Revert of Switching from keepnames to keepclassmembernames for Parcelable
4 years, 4 months ago (2016-08-11 13:26:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240443002/1
4 years, 4 months ago (2016-08-11 13:26:22 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-11 13:26:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240443002/1
4 years, 4 months ago (2016-08-11 13:37:30 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-11 13:37:31 UTC) #9
pkotwicz
4 years, 4 months ago (2016-08-11 14:00:59 UTC) #11
Deleting CL because I started a revert in
https://codereview.chromium.org/2234423002/

Powered by Google App Engine
This is Rietveld 408576698