[iossim] Work around pipe hang on some macs.

[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true

Committed: https://crrev.com/7768f4337363cc5fb41ba14297b4bcff232ccd91
Cr-Commit-Position: refs/heads/master@{#411842}

[rohitrao (ping after 24h), 2016-08-13 00:59:05]

rohitrao@chromium.org changed reviewers:
+ rohitrao@chromium.org

[rohitrao (ping after 24h), 2016-08-13 00:59:05]

lgtm

https://codereview.chromium.org/2240373002/diff/1/testing/iossim/iossim.mm
File testing/iossim/iossim.mm (right):

https://codereview.chromium.org/2240373002/diff/1/testing/iossim/iossim.mm#ne...
testing/iossim/iossim.mm:140: NSData* data = [[out fileHandleForReading]
readDataToEndOfFile];
Add a comment explaining why the code is ordered this way, so that we remember
when we look at this next year.

[justincohen, 2016-08-13 01:01:24]

The CQ bit was checked by justincohen@chromium.org

[justincohen, 2016-08-13 01:01:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2240373002/#ps20001
(title: "Comment")

[justincohen, 2016-08-13 01:02:00]

Description was changed from

==========
[iossim] Work around pipe hang on some macs.

BUG=
==========

to

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
==========

[commit-bot: I haz the power, 2016-08-13 01:02:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincohen, 2016-08-13 01:07:22]

Description was changed from

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
==========

to

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true
==========

[justincohen, 2016-08-13 01:07:29]

The CQ bit was unchecked by justincohen@chromium.org

[justincohen, 2016-08-13 01:07:29]

The CQ bit was checked by justincohen@chromium.org

[commit-bot: I haz the power, 2016-08-13 01:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 01:11:37]

Description was changed from

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true
==========

to

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true
==========

[commit-bot: I haz the power, 2016-08-13 01:11:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-13 01:13:08]

Description was changed from

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true
==========

to

==========
[iossim] Work around pipe hang on some macs.

In the rest of the this file we read from the pipe after -waitUntilExit
(We normally wrap -launch and -waitUntilExit in one -run method).  However,
on some swarming slaves this led to a hang on simctl's pipe.  Since the
output of simctl is so instant, reading it before exit seems to work, and
seems to avoid the hang.

BUG=
NOTRY=true

Committed: https://crrev.com/7768f4337363cc5fb41ba14297b4bcff232ccd91
Cr-Commit-Position: refs/heads/master@{#411842}
==========

[commit-bot: I haz the power, 2016-08-13 01:13:09]

Patchset 2 (id:??) landed as
https://crrev.com/7768f4337363cc5fb41ba14297b4bcff232ccd91
Cr-Commit-Position: refs/heads/master@{#411842}