Issue 2240313002: - Fix for issue 27054 (leak when removing element from _GrowableList)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2240313002: - Fix for issue 27054 (leak when removing element from _GrowableList) (Closed)

Created:
4 years, 4 months ago by siva

Modified:
4 years, 4 months ago

Reviewers:
Cutch, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

- Fix for issue 27054 (leak when removing element from _GrowableList) - _GrowableList.removeLast was not shrinking the backing array BUG=27054 R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cb36467568ed3af7da53c10447d17c05339422bf

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -5 lines)			Patch
	M	runtime/lib/growable_array.dart	View		2 chunks	+14 lines, -4 lines	0 comments	Download
	M	runtime/vm/method_recognizer.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

siva

4 years, 4 months ago (2016-08-12 23:06:16 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cb36467568ed3af7da53c10447d17c05339422bf (presubmit successful).