Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: chrome/browser/ui/views/constrained_window_views_browsertest.cc

Issue 22403003: Update chrome://newtab checks in browser tests to use chrome::IsNTPURL(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/constrained_window_views_browsertest.cc
diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
index fd337fa76b656993147cd2630cc34c0f22ee3418..d9c7f9cf946a2cb37b7e77174ff4922ab1dbe416 100644
--- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc
+++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
@@ -5,6 +5,7 @@
#include "base/memory/weak_ptr.h"
#include "chrome/browser/platform_util.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/search/search.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ -358,7 +359,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowViewTest,
// Wait for the navigation to commit, since the URL will not be visible
// until then.
back_observer.Wait();
- EXPECT_EQ(new_tab_url.spec(), web_contents->GetURL().spec());
+ EXPECT_TRUE(chrome::IsNTPURL(web_contents->GetURL(), browser()->profile()));
}
// Fails flakily (once per 10-20 runs) on Win Aura only. http://crbug.com/177482

Powered by Google App Engine
This is Rietveld 408576698