Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 2240293003: [Mac] Fix for fullscreen toolbar dropdown (Closed)

Created:
4 years, 4 months ago by spqchan
Modified:
4 years, 4 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for fullscreen toolbar dropdown Remove a line that was setting the toolbar fraction to 0, when the fullscreen toolbar is toggled between show and hidden. This was causing the toolbar to have incorrect toolbar fraction values. BUG=634981 Committed: https://crrev.com/18477b7e830c6726c2987e406ce7dd014b418975 Cr-Commit-Position: refs/heads/master@{#411799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
spqchan
PTAL
4 years, 4 months ago (2016-08-12 21:19:04 UTC) #3
Avi (use Gerrit)
lgtm
4 years, 4 months ago (2016-08-12 21:25:19 UTC) #4
spqchan
On 2016/08/12 21:25:19, Avi wrote: > lgtm thanks!
4 years, 4 months ago (2016-08-12 21:28:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240293003/1
4 years, 4 months ago (2016-08-12 21:29:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 22:27:35 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 22:32:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18477b7e830c6726c2987e406ce7dd014b418975
Cr-Commit-Position: refs/heads/master@{#411799}

Powered by Google App Engine
This is Rietveld 408576698