Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2240263002: [Downloads/Phone] Add button to icon row for offlining pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.Activity; 9 import android.app.Activity;
10 import android.app.SearchManager; 10 import android.app.SearchManager;
(...skipping 1513 matching lines...) Expand 10 before | Expand all | Expand 10 after
1524 return false; 1524 return false;
1525 } else if (id == R.id.forward_menu_id) { 1525 } else if (id == R.id.forward_menu_id) {
1526 if (currentTab.canGoForward()) { 1526 if (currentTab.canGoForward()) {
1527 currentTab.goForward(); 1527 currentTab.goForward();
1528 RecordUserAction.record("MobileMenuForward"); 1528 RecordUserAction.record("MobileMenuForward");
1529 RecordUserAction.record("MobileTabClobbered"); 1529 RecordUserAction.record("MobileTabClobbered");
1530 } 1530 }
1531 } else if (id == R.id.bookmark_this_page_id) { 1531 } else if (id == R.id.bookmark_this_page_id) {
1532 addOrEditBookmark(currentTab); 1532 addOrEditBookmark(currentTab);
1533 RecordUserAction.record("MobileMenuAddToBookmarks"); 1533 RecordUserAction.record("MobileMenuAddToBookmarks");
1534 } else if (id == R.id.offline_page_id) {
1535 // TODO(dfalcantara): Hook up offline page downloading.
1534 } else if (id == R.id.reload_menu_id) { 1536 } else if (id == R.id.reload_menu_id) {
1535 if (currentTab.isLoading()) { 1537 if (currentTab.isLoading()) {
1536 currentTab.stopLoading(); 1538 currentTab.stopLoading();
1537 } else { 1539 } else {
1538 currentTab.reload(); 1540 currentTab.reload();
1539 RecordUserAction.record("MobileToolbarReload"); 1541 RecordUserAction.record("MobileToolbarReload");
1540 } 1542 }
1541 } else if (id == R.id.info_menu_id) { 1543 } else if (id == R.id.info_menu_id) {
1542 WebsiteSettingsPopup.show( 1544 WebsiteSettingsPopup.show(
1543 this, currentTab, null, WebsiteSettingsPopup.OPENED_FROM_MEN U); 1545 this, currentTab, null, WebsiteSettingsPopup.OPENED_FROM_MEN U);
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
1765 "Android.MultiWindowMode.IsTabletScreenWidthBelow600", 1767 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
1766 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP); 1768 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
1767 1769
1768 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) { 1770 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
1769 RecordHistogram.recordLinearCountHistogram( 1771 RecordHistogram.recordLinearCountHistogram(
1770 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1, 1772 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
1771 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50); 1773 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
1772 } 1774 }
1773 } 1775 }
1774 } 1776 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698