Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 224023002: Revert of Refactorise the policy_path_parser framework (Closed)

Created:
6 years, 8 months ago by bungeman-skia
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Andrew T Wilson (Slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Refactorise the policy_path_parser framework (https://codereview.chromium.org/214233003/) Reason for revert: Added a static initializer (policy_path_parser_linux.cc__i686.get_pc_thunk.cx), causing sizes on linux to fail. See http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=48755 . Original issue's description: > Refactorise the policy_path_parser framework > > This CL performs a refactorisation of the policy path parser framework. > > BUG=352627 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261370 TBR=pastarmovj@chromium.org,kaliamoorthi@chromium.org NOTREECHECKS=true NOTRY=true BUG=352627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -305 lines) Patch
M chrome/browser/policy/policy_path_parser.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/policy/policy_path_parser.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_linux.cc View 1 chunk +34 lines, -30 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_mac.mm View 2 chunks +66 lines, -59 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_unittest.cc View 2 chunks +7 lines, -43 lines 0 comments Download
M chrome/browser/policy/policy_path_parser_win.cc View 3 chunks +84 lines, -86 lines 0 comments Download
M chrome/policy.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Created Revert of Refactorise the policy_path_parser framework
6 years, 8 months ago (2014-04-03 15:00:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bungeman@google.com/224023002/1
6 years, 8 months ago (2014-04-03 15:04:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 15:04:37 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 15:04:38 UTC) #4
Failed to apply patch for chrome/browser/policy/policy_path_parser.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/policy/policy_path_parser.h
  Hunk #1 FAILED at 7.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/policy/policy_path_parser.h.rej

Patch:       chrome/browser/policy/policy_path_parser.h
Index: chrome/browser/policy/policy_path_parser.h
diff --git a/chrome/browser/policy/policy_path_parser.h
b/chrome/browser/policy/policy_path_parser.h
index
c0d4c222ce858598269eafd34276ccf13b26ac68..5bf03452f7f98b9418f56ce6b183387d3cfb261c
100644
--- a/chrome/browser/policy/policy_path_parser.h
+++ b/chrome/browser/policy/policy_path_parser.h
@@ -7,30 +7,11 @@
 
 #include <string>
 
-#include "base/bind.h"
 #include "base/files/file_path.h"
 
 namespace policy {
 
 namespace path_parser {
-
-namespace internal {
-
-typedef bool (*GetValueFuncPtr)(base::FilePath::StringType*);
-
-struct VariableNameAndValueCallback {
-  const base::FilePath::CharType* name;
-  const GetValueFuncPtr value_func_ptr;
-};
-
-// Different set of variables are supported in each platform (see below). Hence
-// this table is filled in with different elements in each platform.
-extern const VariableNameAndValueCallback kVariableNameAndValueCallbacks[];
-
-// Since the number of elements in the table could vary for each platform, this
-// variable is used to keep track of it.
-extern const int kNoOfVariables;
-}
 
 // This function is used to expand the variables in policy strings that
 // represent paths. The set of supported variables differs between platforms

Powered by Google App Engine
This is Rietveld 408576698