Issue 2240193002: Add --packages flag to test.py, to specify a package spec file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2240193002: Add --packages flag to test.py, to specify a package spec file. (Closed)

Created:
4 years, 4 months ago by Bill Hesse

Modified:
4 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add --packages flag to test.py, to specify a package spec file. BUG=https://github.com/dart-lang/sdk/issues/27063 Committed: https://github.com/dart-lang/sdk/commit/9b8f01f80ea91eb35b98dd52bb177c9409a53d43

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -36 lines)			Patch
M	tools/testing/dart/http_server.dart	View	5 chunks	+13 lines, -4 lines	0 comments	Download
M	tools/testing/dart/test_options.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	5 chunks	+17 lines, -32 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

Committed patchset #1 (id:1) manually as 9b8f01f80ea91eb35b98dd52bb177c9409a53d43 (presubmit successful).

4 years, 4 months ago (2016-08-12 13:44:15 UTC) #4

Søren Gjesse

4 years, 4 months ago (2016-08-15 06:12:58 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/2240193002/diff/1/tools/testing/dart/test_sui...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/2240193002/diff/1/tools/testing/dart/test_sui...
tools/testing/dart/test_suite.dart:1585: String packagesFromFile) {
Indentation.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages