Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 224013004: LeakSanitizer: suppress two leaks in ChromeOS browser tests. (Closed)

Created:
6 years, 8 months ago by earthdok
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

LeakSanitizer: suppress two leaks in ChromeOS browser tests. BUG=354644, 356306 TBR=glider@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tools/lsan/suppressions.txt View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
earthdok
Committed patchset #1 manually as r261480 (presubmit successful).
6 years, 8 months ago (2014-04-03 18:23:05 UTC) #1
Alexander Potapenko
6 years, 8 months ago (2014-04-04 13:08:47 UTC) #2
LGTM

On Thu, Apr 3, 2014 at 10:23 PM,  <earthdok@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Message:
> Committed patchset #1 manually as r261480 (presubmit successful).
>
> Description:
> LeakSanitizer: suppress two leaks in ChromeOS browser tests.
>
> BUG=354644, 356306
> TBR=glider@chromium.org
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261480
>
> Please review this at https://codereview.chromium.org/224013004/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+6, -0 lines):
>   M tools/lsan/suppressions.txt
>
>
> Index: tools/lsan/suppressions.txt
> diff --git a/tools/lsan/suppressions.txt b/tools/lsan/suppressions.txt
> index
>
a71af5bba66fc89d7a70e2e922e0dd10444fc564..837cef5537591ccdc4cf665302e254e2d8c93cfc
> 100644
> --- a/tools/lsan/suppressions.txt
> +++ b/tools/lsan/suppressions.txt
> @@ -101,4 +101,10 @@
> leak:content::SpeechRecognitionBrowserTest::SetUpOnMainThread
>  # http://crbug.com/355641
>  leak:TrayAccessibilityTest
>
> +# http://crbug.com/354644
> +leak:CertificateViewerUITest::ShowModalCertificateViewer
> +
> +# http://crbug.com/356306
> +leak:content::SetProcessTitleFromCommandLine
> +
>  # PLEASE READ ABOVE BEFORE ADDING NEW SUPPRESSIONS.
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698