Fix tearing in video from VideoDestinationHandler

content/renderer/media/webrtc/video_destination_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/webrtc/video_destination_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/logging.h"
@@ skipping 67 matching lines @@
     return;
   }
 
   const gfx::Size frame_size(bitmap->width(), bitmap->height());
 
   if (!first_frame_received_) {
     first_frame_received_ = true;
     format_ = media::VideoCaptureFormat(
         frame_size,
         MediaStreamVideoSource::kDefaultFrameRate,
-        media::PIXEL_FORMAT_I420);
+        media::PIXEL_FORMAT_YV12);
     if (state() == MediaStreamVideoSource::RETRIEVING_CAPABILITIES) {
       media::VideoCaptureFormats formats;
       formats.push_back(format_);
       OnSupportedFormats(formats);
     }
   }
 
   if (state() != MediaStreamVideoSource::STARTED)
     return;
 
   const base::TimeDelta timestamp = base::TimeDelta::FromMilliseconds(
       time_stamp_ns / talk_base::kNumNanosecsPerMillisec);
 
+  // TODO(perkj): It would be more efficient to use I420 here. Using YV12 will
+  // force a copy into a tightly packed I420 frame in
+  // WebRtcVideoCapturerAdapter before the frame is delivered to libJingle.
+  // crbug/359587.
   scoped_refptr<media::VideoFrame> new_frame =
-      frame_pool_.CreateFrame(media::VideoFrame::I420, frame_size,
+      frame_pool_.CreateFrame(media::VideoFrame::YV12, frame_size,
                               gfx::Rect(frame_size), frame_size, timestamp);
 
   libyuv::BGRAToI420(reinterpret_cast<uint8*>(bitmap->getPixels()),
                      bitmap->rowBytes(),
                      new_frame->data(media::VideoFrame::kYPlane),
                      new_frame->stride(media::VideoFrame::kYPlane),
                      new_frame->data(media::VideoFrame::kUPlane),
                      new_frame->stride(media::VideoFrame::kUPlane),
                      new_frame->data(media::VideoFrame::kVPlane),
                      new_frame->stride(media::VideoFrame::kVPlane),
@@ skipping 72 matching lines @@
   stream.addTrack(MediaStreamVideoTrack::CreateVideoTrack(
       writer, constraints, MediaStreamVideoSource::ConstraintsCallback(),
       track_enabled, factory));
 
   *frame_writer = new PpFrameWriterProxy(writer->AsWeakPtr());
   return true;
 }
 
 }  // namespace content