Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2240123002:
[heap] Also mark map when iterating black objects. (Closed)
|
Created:
4 years, 4 months ago by Hannes Payer (out of office) Modified:
4 years, 4 months ago Reviewers:
Michael Lippautz CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Also mark map when iterating black objects.
BUG=chromium:630386
Committed: https://crrev.com/22b931f882be2bf68faad4b240d7ed0126ffa4e4
Cr-Commit-Position: refs/heads/master@{#38609}
Patch Set 1 #Patch Set 2 : move map marking out #Patch Set 3 : move map marking out #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [heap] Call the generic object visitor when visiting black objects. BUG=chromium:630386 ========== to ========== [heap] Call the generic object visitor when visiting black objects. Visistor and black object iterator should visit the exact same fields. BUG=chromium:630386 ==========
hpayer@chromium.org changed reviewers: + mlippautz@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/10877) v8_linux_dbg_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
Description was changed from ========== [heap] Call the generic object visitor when visiting black objects. Visistor and black object iterator should visit the exact same fields. BUG=chromium:630386 ========== to ========== [heap] Also mark map when iterating black objects. BUG=chromium:630386 ==========
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlippautz@chromium.org Link to the patchset: https://codereview.chromium.org/2240123002/#ps40001 (title: "move map marking out")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [heap] Also mark map when iterating black objects. BUG=chromium:630386 ========== to ========== [heap] Also mark map when iterating black objects. BUG=chromium:630386 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Also mark map when iterating black objects. BUG=chromium:630386 ========== to ========== [heap] Also mark map when iterating black objects. BUG=chromium:630386 Committed: https://crrev.com/22b931f882be2bf68faad4b240d7ed0126ffa4e4 Cr-Commit-Position: refs/heads/master@{#38609} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/22b931f882be2bf68faad4b240d7ed0126ffa4e4 Cr-Commit-Position: refs/heads/master@{#38609} |
