[Android] Fix v8_use_external_startup_data = false.

[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with v8_use_external_startup_data = false.

BUG=

Committed: https://crrev.com/038d50494a3a05ef510a877ae1fd27c27a71cacd
Cr-Commit-Position: refs/heads/master@{#413039}

[Eden Wang, 2016-08-12 09:04:24]

Description was changed from

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=
==========

to

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=
==========

[Eden Wang, 2016-08-12 09:04:24]

nedenwang@tencent.com changed reviewers:
+ jamesxwei@tencent.com, tobiasjs@chromium.org

[Eden Wang, 2016-08-12 09:06:54]

Hi altimin,
  I have got some compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false,
kV8NativesDataDescriptor/kV8SnapshotDataDescriptor32/kV8SnapshotDataDescriptor64/gin::V8Initializer::GetSnapshotFilePath
are undefined.

[Eden Wang, 2016-08-12 09:22:04]

On 2016/08/12 09:06:54, Eden Wang wrote:
> Hi altimin,
>   I have got some compiler errors while building Android WebView Shell with
> v8_use_external_startup_data = false,
>
kV8NativesDataDescriptor/kV8SnapshotDataDescriptor32/kV8SnapshotDataDescriptor64/gin::V8Initializer::GetSnapshotFilePath
> are undefined.

Hi tobiasjs,
   I'm so Sorry, I have just delivery a mail to altimin and I forgot to change
the name.

[Tobias Sargeant, 2016-08-12 09:26:31]

No problem. LGTM, but I'm not sure that v8_use_external_startup_data = false is
a tested configuration. Is there any reason you need it?

[Torne, 2016-08-12 09:28:47]

On 2016/08/12 09:26:31, Tobias Sargeant wrote:
> No problem. LGTM, but I'm not sure that v8_use_external_startup_data = false
is
> a tested configuration. Is there any reason you need it?

Yeah; don't use this config, use the default and have external startup data; it
produces better update sizes and there's no downside that we're aware of.

[Eden Wang, 2016-08-12 11:30:03]

On 2016/08/12 09:28:47, Torne wrote:
> On 2016/08/12 09:26:31, Tobias Sargeant wrote:
> > No problem. LGTM, but I'm not sure that v8_use_external_startup_data = false
> is
> > a tested configuration. Is there any reason you need it?
> 
> Yeah; don't use this config, use the default and have external startup data;
it
> produces better update sizes and there's no downside that we're aware of.

we are using chromium as a web enginee for our product and need to package all
binaries in one .so library. So we need to use chromium with
v8_use_external_startup_data as false.

[Eden Wang, 2016-08-12 11:58:37]

nedenwang@tencent.com changed reviewers:
+ torne@chromium.org

[Eden Wang, 2016-08-12 11:59:56]

The CQ bit was checked by nedenwang@tencent.com

[commit-bot: I haz the power, 2016-08-12 12:00:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:00:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 12:00:15]

The author nedenwang@tencent.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[Eden Wang, 2016-08-19 02:17:05]

The CQ bit was checked by nedenwang@tencent.com

[commit-bot: I haz the power, 2016-08-19 02:17:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 03:03:40]

Description was changed from

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=
==========

to

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=
==========

[commit-bot: I haz the power, 2016-08-19 03:03:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-19 03:05:27]

Description was changed from

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=
==========

to

==========
[Android] Fix v8_use_external_startup_data = false.

There are compiler errors while building Android WebView Shell with
v8_use_external_startup_data = false.

BUG=

Committed: https://crrev.com/038d50494a3a05ef510a877ae1fd27c27a71cacd
Cr-Commit-Position: refs/heads/master@{#413039}
==========

[commit-bot: I haz the power, 2016-08-19 03:05:28]

Patchset 1 (id:??) landed as
https://crrev.com/038d50494a3a05ef510a877ae1fd27c27a71cacd
Cr-Commit-Position: refs/heads/master@{#413039}