Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: src/runtime.cc

Issue 22401008: Return i18n object holders directly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 6213594155d909ff898f01daa5290065e1a6067c..56aa19ef0eec91a3b94a4c4e2691a4cd3baca6e4 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -13619,9 +13619,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_CreateDateTimeFormat) {
v8::Utils::ToLocal(local_object));
// Make object handle weak so we can delete the data format once GC kicks in.
wrapper.MakeWeak<void>(NULL, &DateFormat::DeleteDateFormat);
- Handle<Object> result = Utils::OpenPersistent(wrapper);
wrapper.ClearAndLeak();
- return *result;
+ return *local_object;
}
@@ -13724,9 +13723,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_CreateNumberFormat) {
// Make object handle weak so we can delete the number format once GC kicks
// in.
wrapper.MakeWeak<void>(NULL, &NumberFormat::DeleteNumberFormat);
- Handle<Object> result = Utils::OpenPersistent(wrapper);
wrapper.ClearAndLeak();
- return *result;
+ return *local_object;
}
@@ -13837,9 +13835,8 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_CreateCollator) {
v8::Utils::ToLocal(local_object));
// Make object handle weak so we can delete the collator once GC kicks in.
wrapper.MakeWeak<void>(NULL, &Collator::DeleteCollator);
- Handle<Object> result = Utils::OpenPersistent(wrapper);
wrapper.ClearAndLeak();
- return *result;
+ return *local_object;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698