Remove stl_util's STLDeleteContainerPairPointers.

Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865, 556939
Committed: https://crrev.com/d99bd1a3a659975bc78b4b2dcb900537c0ef761b
Cr-Commit-Position: refs/heads/master@{#412674}

[Avi (use Gerrit), 2016-08-12 20:32:18]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 20:32:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 20:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 20:35:23]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Avi (use Gerrit), 2016-08-12 20:52:36]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 20:52:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:02:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-08-12 22:51:22]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 22:51:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 22:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 22:55:47]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Avi (use Gerrit), 2016-08-12 23:24:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 23:25:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-08-12 23:44:32]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939
==========

to

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939
==========

[Avi (use Gerrit), 2016-08-12 23:44:32]

avi@chromium.org changed reviewers:
+ groby@chromium.org, mark@chromium.org, mattm@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:28:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-13 02:28:12]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-13 04:45:29]

groby: spellchecker
mattm: safe browsing
mark: base

[Avi (use Gerrit), 2016-08-16 15:56:53]

On 2016/08/13 04:45:29, Avi wrote:
> groby: spellchecker
> mattm: safe browsing
> mark: base

Ping?

[Mark Mentovai, 2016-08-16 16:43:48]

LGTM in base

[mattm, 2016-08-16 20:41:22]

Nice cleanup, just a few nits.

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service.cc (right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service.cc:288:
net::URLFetcher* fetcher =
Would be cleaner to store the temporaries as unique_ptrs instead of bare
pointers that later get wrapped.

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
(right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service_unittest.cc:158:
csd_service_->cache_[gurl] = base::WrapUnique(
Use MakeUnique instead of WrapUnique? (see chromium-dev thread) (applies
elsewhere too)

[groby-ooo-7-16, 2016-08-17 16:34:17]

Neat.

LGTM, and a question just for my own curiosity: Why not make the callback data
move-only and get rid of a bunch of ptr handling for that?

[Avi (use Gerrit), 2016-08-17 16:38:54]

On 2016/08/17 16:34:17, groby wrote:
> Neat.
> 
> LGTM, and a question just for my own curiosity: Why not make the callback data
> move-only and get rid of a bunch of ptr handling for that?

Mostly because getting rid of the stl_util functions are a side project for me,
and I'm not very familiar with a lot of the code in which I'm working. I'm
trying to not make CLs that are obviously sub-optimal, but I'm trying to not go
crazy and rewrite everyone else's code, either.

[Avi (use Gerrit), 2016-08-17 18:01:09]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 18:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 18:05:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Avi (use Gerrit), 2016-08-17 18:25:37]

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service.cc (right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service.cc:288:
net::URLFetcher* fetcher =
On 2016/08/16 20:41:22, mattm wrote:
> Would be cleaner to store the temporaries as unique_ptrs instead of bare
> pointers that later get wrapped.

Hmmm. Once we move them, then we can't use the temporaries. I'll rewrite but I'm
not sure how much cleaner it is.

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
(right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service_unittest.cc:158:
csd_service_->cache_[gurl] = base::WrapUnique(
On 2016/08/16 20:41:22, mattm wrote:
> Use MakeUnique instead of WrapUnique? (see chromium-dev thread) (applies
> elsewhere too)

Sometimes MakeUnique works, sometimes it fails for access reasons or Create()
functions. I'm unfamiliar with a lot of this code, and sometimes I use
WrapUnique just because it's the most minimally-invasive way to do the
conversion.

[Avi (use Gerrit), 2016-08-17 18:32:59]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:05:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:05:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-08-17 19:22:32]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:22:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:07:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:07:57]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-17 21:22:01]

mattm, ptal.

[mattm, 2016-08-17 21:28:34]

lgtm

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
(right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service_unittest.cc:158:
csd_service_->cache_[gurl] = base::WrapUnique(
On 2016/08/17 18:25:37, Avi wrote:
> On 2016/08/16 20:41:22, mattm wrote:
> > Use MakeUnique instead of WrapUnique? (see chromium-dev thread) (applies
> > elsewhere too)
> 
> Sometimes MakeUnique works, sometimes it fails for access reasons or Create()
> functions. I'm unfamiliar with a lot of this code, and sometimes I use
> WrapUnique just because it's the most minimally-invasive way to do the
> conversion.

nit: Could you update the other ones in here too?

[Avi (use Gerrit), 2016-08-17 21:34:55]

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
File chrome/browser/safe_browsing/client_side_detection_service_unittest.cc
(right):

https://codereview.chromium.org/2240083004/diff/40001/chrome/browser/safe_bro...
chrome/browser/safe_browsing/client_side_detection_service_unittest.cc:158:
csd_service_->cache_[gurl] = base::WrapUnique(
On 2016/08/17 21:28:34, mattm wrote:
> On 2016/08/17 18:25:37, Avi wrote:
> > On 2016/08/16 20:41:22, mattm wrote:
> > > Use MakeUnique instead of WrapUnique? (see chromium-dev thread) (applies
> > > elsewhere too)
> > 
> > Sometimes MakeUnique works, sometimes it fails for access reasons or
Create()
> > functions. I'm unfamiliar with a lot of this code, and sometimes I use
> > WrapUnique just because it's the most minimally-invasive way to do the
> > conversion.
> 
> nit: Could you update the other ones in here too?

Done.

[Avi (use Gerrit), 2016-08-17 21:35:18]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-08-17 21:35:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
groby@chromium.org, mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2240083004/#ps120001
(title: "mattm")

[commit-bot: I haz the power, 2016-08-17 21:35:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 22:44:24]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939
==========

to

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939
==========

[commit-bot: I haz the power, 2016-08-17 22:44:26]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-17 22:46:21]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939
==========

to

==========
Remove stl_util's STLDeleteContainerPairPointers.

Along the way, remove some linked_ptr usage, too.

BUG=555865,556939

Committed: https://crrev.com/d99bd1a3a659975bc78b4b2dcb900537c0ef761b
Cr-Commit-Position: refs/heads/master@{#412674}
==========

[commit-bot: I haz the power, 2016-08-17 22:46:24]

Patchset 7 (id:??) landed as
https://crrev.com/d99bd1a3a659975bc78b4b2dcb900537c0ef761b
Cr-Commit-Position: refs/heads/master@{#412674}