Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2240073002: Revert of Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex (Closed)

Created:
4 years, 4 months ago by hajimehoshi
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex (patchset #1 id:1 of https://codereview.chromium.org/2225903004/ ) Reason for revert: Crash reported at crbug.com/636829 Original issue's description: > Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex > > DeferredImageDecoder::createFrameAtIndex is used only at > ImageSource::createFrameAtIndex, and this is indirectly called by > BitmapImage::frameAtIndex, which checks that the index is less than the > number of frames. Thus, DeferredImageDecoder::createFrameAtIndex can > assume that the given |index| is less than the number of the frames. > > This CL removes the dead code to improve code health. > > BUG=n/a > TEST=webkit_unit_tests > > Committed: https://crrev.com/9a1a7dc0502f5d16b53ce50a2fd509b0ea5cf125 > Cr-Commit-Position: refs/heads/master@{#410961} TBR=fmalita@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=n/a Committed: https://crrev.com/3831b72130f11ebac151fd4945719f6d7489e048 Cr-Commit-Position: refs/heads/master@{#411559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp View 1 chunk +20 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
hajimehoshi
Created Revert of Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex
4 years, 4 months ago (2016-08-12 04:34:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240073002/1
4 years, 4 months ago (2016-08-12 04:34:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 05:39:41 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 05:41:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3831b72130f11ebac151fd4945719f6d7489e048
Cr-Commit-Position: refs/heads/master@{#411559}

Powered by Google App Engine
This is Rietveld 408576698