DescriptionRevert of Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex (patchset #1 id:1 of https://codereview.chromium.org/2225903004/ )
Reason for revert:
Crash reported at crbug.com/636829
Original issue's description:
> Refactoring: Remove dead code in DeferredImageDecoder::createFrameAtIndex
>
> DeferredImageDecoder::createFrameAtIndex is used only at
> ImageSource::createFrameAtIndex, and this is indirectly called by
> BitmapImage::frameAtIndex, which checks that the index is less than the
> number of frames. Thus, DeferredImageDecoder::createFrameAtIndex can
> assume that the given |index| is less than the number of the frames.
>
> This CL removes the dead code to improve code health.
>
> BUG=n/a
> TEST=webkit_unit_tests
>
> Committed: https://crrev.com/9a1a7dc0502f5d16b53ce50a2fd509b0ea5cf125
> Cr-Commit-Position: refs/heads/master@{#410961}
TBR=fmalita@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=n/a
Committed: https://crrev.com/3831b72130f11ebac151fd4945719f6d7489e048
Cr-Commit-Position: refs/heads/master@{#411559}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|