Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with --vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL also adds a stream printer for WTF::CString.

This CL doesn't affect production.

BUG=596760
Committed: https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581
Cr-Commit-Position: refs/heads/master@{#411588}

[tkent, 2016-08-12 04:02:37]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 04:02:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-12 04:05:45]

tkent@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tkent, 2016-08-12 04:05:46]

tyoshino@, would you review this please?

https://codereview.chromium.org/2240053002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp (right):

https://codereview.chromium.org/2240053002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp:287:
NETWORK_DVLOG(1) << "WebSocket " << this << " connect() url=" << url;
Patch Set 1 doesn't introduce a stream printer for DOMWebSocket like
XMLHttpRequest and DocumentWebSocketChannel because the C++ class name
'DOMWebSocket' and the log prefix 'WebSocket' are mismatched.

Also, I wonder if we need such prefixes though DVLOG() shows source code file
names by default.

[commit-bot: I haz the power, 2016-08-12 04:06:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 04:06:28]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tkent, 2016-08-12 04:07:01]

oops, forgot to add new files.

[tkent, 2016-08-12 04:07:35]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 04:07:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-12 04:08:30]

Description was changed from

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. This CL introduce NETWORK_DVLOG(level), which shows
logs with --vmodule=NetworkLog=N, and RESOURCE_LOADING_DVLOG(level), which shows
logs with --vmodule=ResourceLoadingLog=N, and replace WTF_LOG(Network, ...) and
WTF_LOG(ResourceLoading, ...).

This CL doesn't affect production.

BUG=596760
==========

to

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with
--vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL doesn't affect production.

BUG=596760
==========

[tkent, 2016-08-12 04:48:26]

Now this is ready for review.

[tyoshino (SeeGerritForStatus), 2016-08-12 04:50:49]

lgtm

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/MemoryCache.cpp (right):

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/MemoryCache.cpp:170:
RESOURCE_LOADING_DVLOG(1) << "MemoryCache::add Added " <<
resource->url().getString() << ", resource " << resource;
I see. operator<< will print double quotations instead of the single quotations

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp (right):

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp:397:
NETWORK_DVLOG(1) << "WebSocket " << this << " send() Sending String '" <<
encodedMessage.data() << "'";
as we're switching to double quotations for WTFString printing, shall we use "
here too for char* printing?

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp:195:
NETWORK_DVLOG(1) << this << " sendText(" << message.data() << ")";
add double quotations for consistency?

[tyoshino (SeeGerritForStatus), 2016-08-12 04:52:28]

Oh, I'm not sure files I looked at are all in ps2. I'll check later after
meeting.

[tkent, 2016-08-12 05:34:38]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 05:34:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-12 05:37:18]

Uploaded a new patch set.

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp (right):

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp:397:
NETWORK_DVLOG(1) << "WebSocket " << this << " send() Sending String '" <<
encodedMessage.data() << "'";
On 2016/08/12 at 04:50:49, tyoshino wrote:
> as we're switching to double quotations for WTFString printing, shall we use "
here too for char* printing?

Done.  This function has |const String& message|. So new patch set just put
|message| here.

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
(right):

https://codereview.chromium.org/2240053002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp:195:
NETWORK_DVLOG(1) << this << " sendText(" << message.data() << ")";
On 2016/08/12 at 04:50:49, tyoshino wrote:
> add double quotations for consistency?

I added CString stream printer.  Please see wtf/text/CString.* in the new patch
set.
The code here is now just |" sendText(" << message << ")";|.

[tyoshino (SeeGerritForStatus), 2016-08-12 05:57:38]

lgtm

https://codereview.chromium.org/2240053002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp (right):

https://codereview.chromium.org/2240053002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp:287:
NETWORK_DVLOG(1) << "WebSocket " << this << " connect() url=" << url;
On 2016/08/12 04:05:46, tkent wrote:
> Patch Set 1 doesn't introduce a stream printer for DOMWebSocket like
> XMLHttpRequest and DocumentWebSocketChannel because the C++ class name
> 'DOMWebSocket' and the log prefix 'WebSocket' are mismatched.
> 
> Also, I wonder if we need such prefixes though DVLOG() shows source code file
> names by default.

I see. I agree it's redundant. But it's good to have some string before the
pointer to indicate what the pointer is.  E.g. "this=". Changing WebSocket here
to DOMWebSocket is fine.

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/CStringTest.cpp (right):

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/CStringTest.cpp:28: #include
"testing/gtest/include/gtest/gtest.h"
include sstream

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/CStringTest.cpp:217:
EXPECT_EQ(CString("\"\\xFF\\x00\\x01\""), printedString(CString("\xff\0\x01",
3)));
using CString also for the expectation side to check non-escaped inputs at once?

[tkent, 2016-08-12 06:34:54]

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/CStringTest.cpp (right):

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/CStringTest.cpp:28: #include
"testing/gtest/include/gtest/gtest.h"
On 2016/08/12 at 05:57:38, tyoshino wrote:
> include sstream

Done.

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/CStringTest.cpp:217:
EXPECT_EQ(CString("\"\\xFF\\x00\\x01\""), printedString(CString("\xff\0\x01",
3)));
On 2016/08/12 at 05:57:38, tyoshino wrote:
> using CString also for the expectation side to check non-escaped inputs at
once?

It isn't so meaningful.  I thought returning char* from printedString() was hard
because of a lifetime issue.
However I realized EXPECT_STREQ("...", printedString(...).data()) worked.

[tkent, 2016-08-12 06:35:12]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-08-12 06:35:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/2240053002/#ps60001
(title: "sstream, EXPECT_STREQ")

[commit-bot: I haz the power, 2016-08-12 06:35:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2016-08-12 06:35:37]

Description was changed from

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with
--vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL doesn't affect production.

BUG=596760
==========

to

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with
--vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL also adds a stream printer for WTF::CString.

This CL doesn't affect production.

BUG=596760
==========

[tyoshino (SeeGerritForStatus), 2016-08-12 06:38:31]

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/wtf/text/CStringTest.cpp (right):

https://codereview.chromium.org/2240053002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/wtf/text/CStringTest.cpp:217:
EXPECT_EQ(CString("\"\\xFF\\x00\\x01\""), printedString(CString("\xff\0\x01",
3)));
On 2016/08/12 06:34:54, tkent wrote:
> On 2016/08/12 at 05:57:38, tyoshino wrote:
> > using CString also for the expectation side to check non-escaped inputs at
> once?
> 
> It isn't so meaningful.  I thought returning char* from printedString() was
hard
> because of a lifetime issue.
> However I realized EXPECT_STREQ("...", printedString(...).data()) worked.

Acknowledged.

[tyoshino (SeeGerritForStatus), 2016-08-12 07:32:19]

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:594:
RESOURCE_LOADING_DVLOG(1) << "Loading Resource for " <<
request.resourceRequest().url().elidedString();
oh, does this change make this line run .elidedString() even for release build?

if so, it's ok to commit this first but later ideally we should add some
if-clause to skip this?

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp (right):

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp:555:
NETWORK_DVLOG(1) << this << " open(" << method << ", " << url.elidedString() <<
", " << async << ")";
ditto

[tkent, 2016-08-12 07:43:45]

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:594:
RESOURCE_LOADING_DVLOG(1) << "Loading Resource for " <<
request.resourceRequest().url().elidedString();
On 2016/08/12 at 07:32:19, tyoshino wrote:
> oh, does this change make this line run .elidedString() even for release
build?
> 
> if so, it's ok to commit this first but later ideally we should add some
if-clause to skip this?

Both of clang and MSVC are clever enough.  They don't produce any code for this
line in Release build.

[tyoshino (SeeGerritForStatus), 2016-08-12 07:57:06]

On 2016/08/12 07:43:45, unavailable_until_Aug17 wrote:
>
https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp (right):
> 
>
https://codereview.chromium.org/2240053002/diff/60001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp:594:
> RESOURCE_LOADING_DVLOG(1) << "Loading Resource for " <<
> request.resourceRequest().url().elidedString();
> On 2016/08/12 at 07:32:19, tyoshino wrote:
> > oh, does this change make this line run .elidedString() even for release
> build?
> > 
> > if so, it's ok to commit this first but later ideally we should add some
> if-clause to skip this?
> 
> Both of clang and MSVC are clever enough.  They don't produce any code for
this
> line in Release build.

Got it. Thanks

[commit-bot: I haz the power, 2016-08-12 10:05:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-12 10:07:04]

Description was changed from

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with
--vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL also adds a stream printer for WTF::CString.

This CL doesn't affect production.

BUG=596760
==========

to

==========
Replace WTF_LOG() with NETWORK_DVLOG() or RESOURCE_LOADING_DVLOG().

WTF_LOG() is deprecated. Like crrev.com/411499, this CL introduce
NETWORK_DVLOG(level), which shows logs with --vmodule=NetworkLog=N, and
RESOURCE_LOADING_DVLOG(level), which shows logs with
--vmodule=ResourceLoadingLog=N,
and replace WTF_LOG(Network, ...) and WTF_LOG(ResourceLoading, ...).

This CL also adds a stream printer for WTF::CString.

This CL doesn't affect production.

BUG=596760

Committed: https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581
Cr-Commit-Position: refs/heads/master@{#411588}
==========

[commit-bot: I haz the power, 2016-08-12 10:07:06]

Patchset 4 (id:??) landed as
https://crrev.com/b300917ad36438a8bcf700980f8991bf55cf2581
Cr-Commit-Position: refs/heads/master@{#411588}