Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2240043002: Remove WTF_LOG(). (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
halliwell, piman
CC:
darktears, blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, kinuko+watch, Mikhail, rjwright, nessy, tzik, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTF_LOG(). No one uses it. The command-line flag --blink-platform-log-channels is also removed. It affects nothing. BUG=596760 Committed: https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8 Cr-Commit-Position: refs/heads/master@{#412440}

Patch Set 1 : foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -178 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M content/test/blink_test_environment.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/platform/Logging.h View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/Source/platform/Logging.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIteratorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 2 chunks +0 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/ScopedLogger.md View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebKit.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 31 (24 generated)
tkent
pfeldman@, would you review this please? This is a trivial code removal CL. halliwell@, would ...
4 years, 4 months ago (2016-08-12 14:53:36 UTC) #19
halliwell
On 2016/08/12 14:53:36, unavailable_until_Aug17 wrote: > pfeldman@, would you review this please? This is a ...
4 years, 4 months ago (2016-08-12 14:57:54 UTC) #20
tkent
Can any content owner approve this trivial CL?
4 years, 4 months ago (2016-08-16 22:56:19 UTC) #24
piman
lgtm
4 years, 4 months ago (2016-08-17 00:28:56 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240043002/40001
4 years, 4 months ago (2016-08-17 00:38:31 UTC) #28
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-17 03:20:45 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 03:23:37 UTC) #31
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0316d5ad84ef5409cabb2b477fc4c5864604f9e8
Cr-Commit-Position: refs/heads/master@{#412440}

Powered by Google App Engine
This is Rietveld 408576698