[MD settings] extension exceptions in site settings

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-site-list' shows a list of Allowed and Blocked sites for a given
  * category.
  */
 Polymer({
@@ skipping 284 matching lines @@
    * Converts a string origin/pattern to a URL.
    * @param {string} originOrPattern The origin/pattern to convert to URL.
    * @return {URL} The URL to return (or null if origin is not a valid URL).
    * @private
    */
   toUrl_: function(originOrPattern) {
     if (originOrPattern.length == 0)
       return null;
     // TODO(finnur): Hmm, it would probably be better to ensure scheme on the
     //     JS/C++ boundary.
-    return new URL(
-        this.ensureUrlHasScheme(originOrPattern.replace('[*.]', '')));
+    // TODO(dschuyler): I agree. This filtering should be done in one go, rather
+    // that during the sort. The URL generation should be wrapped in a try/catch
+    // as well.

[Finnur, 2016/08/12 15:36:39]

Sounds good.

On a related note:
https://bugs.chromium.org/p/chromium/issues/detail?id=636982

[dschuyler, 2016/08/12 19:21:13]

Acknowledged.

+    originOrPattern = originOrPattern.replace('*://', '');
+    originOrPattern = originOrPattern.replace('[*.]', '');
+    return new URL(this.ensureUrlHasScheme(originOrPattern));
   },
 
   /**
    * Converts an unordered site list to an ordered array, sorted by site name
    * then protocol and de-duped (by origin).
    * @param {!Array<SiteException>} sites A list of sites to sort and de-dupe.
    * @return {!Array<SiteException>} Sorted and de-duped list.
    * @private
    */
   toSiteArray_: function(sites) {
@@ skipping 156 matching lines @@
     // is redundant to also list all the sites that are blocked.
     if (this.isAllowList_())
       return true;
 
     if (this.isSessionOnlyList_())
       return siteList.length > 0;
 
     return toggleState;
   },
 });