Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2240003002: Rust: Polish off communication across Mojom interfaces (Closed)

Created:
4 years, 4 months ago by mknyszek
Modified:
4 years, 4 months ago
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rust: Polish off communication across Mojom interfaces Adds in better error handling to communicating across interfaces and polishes the convenience methods for writing and reading Mojom structs from an interface. Also includes a test which acts a rudimentary example on how to use Mojom interfaces in Rust. R=eholk@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/545970c4b4b507e88d42fe779d7c32eab8f86e03

Patch Set 1 #

Patch Set 2 : Upload newest version of code gen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+910 lines, -567 lines) Patch
M mojo/public/rust/src/bindings/macros.rs View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/public/rust/src/bindings/message.rs View 4 chunks +3 lines, -7 lines 0 comments Download
M mojo/public/rust/src/bindings/mojom.rs View 8 chunks +57 lines, -20 lines 0 comments Download
M mojo/public/rust/tests/encoding.rs View 1 chunk +30 lines, -0 lines 0 comments Download
A mojo/public/rust/tests/integration.rs View 1 chunk +67 lines, -0 lines 0 comments Download
M mojo/public/rust/tests/util/mojom_validation.rs View 48 chunks +690 lines, -508 lines 0 comments Download
M mojo/public/rust/tests/validation.rs View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_tool/bin/linux64/generators/rust.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M mojom/generators/rust/rustgen/source.go View 4 chunks +17 lines, -1 line 0 comments Download
M mojom/generators/rust/templates/interface.tmpl.go View 4 chunks +36 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mknyszek
4 years, 4 months ago (2016-08-12 00:59:10 UTC) #2
Eric Holk
lgtm
4 years, 4 months ago (2016-08-12 01:27:44 UTC) #3
mknyszek
4 years, 4 months ago (2016-08-12 18:10:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
545970c4b4b507e88d42fe779d7c32eab8f86e03 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698