net/cert/cert_verify_proc.cc - Issue 2239963002: Add enterprise policy to allow locally issued SHA-1 certificates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc.cc

Issue 2239963002: Add enterprise policy to allow locally issued SHA-1 certificates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc.cc

diff --git a/net/cert/cert_verify_proc.cc b/net/cert/cert_verify_proc.cc

index 87541ae3673014388c9e27303913e56dd8ddc860..8fdd93cbb1bb0c4720273867ee9c9de3fb723ed6 100644

--- a/net/cert/cert_verify_proc.cc

+++ b/net/cert/cert_verify_proc.cc

@@ -440,6 +440,9 @@ int CertVerifyProc::Verify(X509Certificate* cert,

// disabled on this date, but enterprises need more time to transition.

// As the risk is greatest for publicly trusted certificates, prevent

// those certificates from being trusted from that date forward.

+ //

+ // TODO(mattm): apply the SHA-1 deprecation check to all certs unless

+ // CertVerifier::VERIFY_ENABLE_SHA1_LOCAL_ANCHORS flag is present.

if (verify_result->has_md5 ||

(verify_result->has_sha1_leaf && verify_result->is_issued_by_known_root &&

IsPastSHA1DeprecationDate(*cert))) {

« no previous file with comments | « net/cert/cert_verifier.h ('k') | net/ssl/ssl_config.h » ('j') | no next file with comments »