Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2239953002: Fix extraneous double-handled event errors. (Closed)

Created:
4 years, 4 months ago by alexandermont
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fix extraneous double-handled event errors. The user model will frequently report double-handled event errors when there are two or more animations overlapping, because the frames in the animation intervals are considered associatedEvents for those animations, so if the animations overlap then the frame will be the associatedEvent of two or more different animations. Since this is expected, we will no longer report a double-handled event error on a frame event (but will still report these errors on other types of events) BUG=catapult:#2664 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/8be763db2940432ebf6f6d188894e2af845bbf1a

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tracing/tracing/importer/find_input_expectations.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
alexandermont
4 years, 4 months ago (2016-08-11 23:17:13 UTC) #2
charliea (OOO until 10-5)
lgtm, but deferring to benjhayden@ for final approval because he knows this code a lot ...
4 years, 4 months ago (2016-08-12 13:35:22 UTC) #4
benjhayden
https://codereview.chromium.org/2239953002/diff/1/tracing/tracing/importer/find_input_expectations.html File tracing/tracing/importer/find_input_expectations.html (right): https://codereview.chromium.org/2239953002/diff/1/tracing/tracing/importer/find_input_expectations.html#newcode74 tracing/tracing/importer/find_input_expectations.html:74: var FRAME_EVENT_TITLE = 'BenchmarkInstrumentation::ImplThreadRenderingStats'; Can you reference tr.model.helpers.IMPL_RENDERING_STATS instead ...
4 years, 4 months ago (2016-08-15 22:14:55 UTC) #5
alexandermont
4 years, 4 months ago (2016-08-15 23:08:37 UTC) #6
alexandermont
https://codereview.chromium.org/2239953002/diff/1/tracing/tracing/importer/find_input_expectations.html File tracing/tracing/importer/find_input_expectations.html (right): https://codereview.chromium.org/2239953002/diff/1/tracing/tracing/importer/find_input_expectations.html#newcode74 tracing/tracing/importer/find_input_expectations.html:74: var FRAME_EVENT_TITLE = 'BenchmarkInstrumentation::ImplThreadRenderingStats'; On 2016/08/15 at 22:14:55, benjhayden ...
4 years, 4 months ago (2016-08-15 23:08:55 UTC) #7
benjhayden
lgtm
4 years, 4 months ago (2016-08-15 23:09:56 UTC) #8
alexandermont
4 years, 4 months ago (2016-08-15 23:19:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239953002/20001
4 years, 4 months ago (2016-08-17 22:54:01 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 00:47:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698