Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2239943003: Enable incremental linking for unit_tests on win component (Closed)

Created:
4 years, 4 months ago by scottmg
Modified:
4 years, 4 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable incremental linking for unit_tests on win component browser_tests seems ok so far, and unit_tests is a bit smaller currently. R=brettw@chromium.org BUG=636468 Committed: https://crrev.com/28a2bfe1e7db4c74017c86f5b8ba9ec2b61c238e Cr-Commit-Position: refs/heads/master@{#411788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M chrome/test/BUILD.gn View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
scottmg
4 years, 4 months ago (2016-08-12 20:09:58 UTC) #1
brettw
lgtm
4 years, 4 months ago (2016-08-12 20:11:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239943003/1
4 years, 4 months ago (2016-08-12 21:05:28 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 21:49:27 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 21:52:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28a2bfe1e7db4c74017c86f5b8ba9ec2b61c238e
Cr-Commit-Position: refs/heads/master@{#411788}

Powered by Google App Engine
This is Rietveld 408576698