LightingFP now supports multiple directional lights

LightingFP now supports multiple directional lights

BUG=skia:5518
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004

Committed: https://skia.googlesource.com/skia/+/6ad75d10eb2462e614f2b7cba293144a7e91a842

[dvonbeck, 2016-08-12 16:05:59]

Description was changed from

==========
LightingFP now supports multiple directional lights

BUG=skia:
==========

to

==========
LightingFP now supports multiple directional lights

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004
==========

[dvonbeck, 2016-08-12 16:11:33]

Description was changed from

==========
LightingFP now supports multiple directional lights

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004
==========

to

==========
LightingFP now supports multiple directional lights

BUG=skia:5518
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004
==========

[dvonbeck, 2016-08-12 16:12:09]

dvonbeck@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[dvonbeck, 2016-08-12 16:12:09]

Tested locally. GMs that test this incoming.

[dvonbeck, 2016-08-12 16:34:21]

GM that tests this is up!

[egdaniel, 2016-08-15 15:13:09]

https://codereview.chromium.org/2239933004/diff/60001/src/core/SkLightingShad...
File src/core/SkLightingShader.cpp (right):

https://codereview.chromium.org/2239933004/diff/60001/src/core/SkLightingShad...
src/core/SkLightingShader.cpp:218: SkTArray<SkColor3f>
lightDirs(directionalLights.count());
I current don't have a good suggestion how, but it would be really nice to avoid
some of the copying we're doing in this if state. We copy all the data once to
the individual arrays and again in the end to the fDirectionalLights (not
counting the copying of data onto the GPU).

[dvonbeck, 2016-08-15 15:25:09]

https://codereview.chromium.org/2239933004/diff/60001/src/core/SkLightingShad...
File src/core/SkLightingShader.cpp (right):

https://codereview.chromium.org/2239933004/diff/60001/src/core/SkLightingShad...
src/core/SkLightingShader.cpp:218: SkTArray<SkColor3f>
lightDirs(directionalLights.count());
On 2016/08/15 15:13:09, egdaniel wrote:
> I current don't have a good suggestion how, but it would be really nice to
avoid
> some of the copying we're doing in this if state. We copy all the data once to
> the individual arrays and again in the end to the fDirectionalLights (not
> counting the copying of data onto the GPU).

Based on what we talked, I will leave this as-is for the moment, since there is
no clean solution. It needs to be changed if it ends up affecting performance.

[egdaniel, 2016-08-15 15:42:26]

lgtm

[dvonbeck, 2016-08-15 15:42:34]

The CQ bit was checked by dvonbeck@google.com

[commit-bot: I haz the power, 2016-08-15 15:42:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 15:44:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 15:44:13]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[reed1, 2016-08-15 18:32:25]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-08-15 18:32:26]

api lgtm

[dvonbeck, 2016-08-15 18:34:55]

The CQ bit was checked by dvonbeck@google.com

[commit-bot: I haz the power, 2016-08-15 18:35:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 18:35:58]

Description was changed from

==========
LightingFP now supports multiple directional lights

BUG=skia:5518
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004
==========

to

==========
LightingFP now supports multiple directional lights

BUG=skia:5518
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239933004

Committed:
https://skia.googlesource.com/skia/+/6ad75d10eb2462e614f2b7cba293144a7e91a842
==========

[commit-bot: I haz the power, 2016-08-15 18:35:59]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ad75d10eb2462e614f2b7cba293144a7e91a842