Issue 223993002: Revert of Refactorise the policy_path_parser framework

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 223993002: Revert of Refactorise the policy_path_parser framework (Closed)

Created:
6 years, 8 months ago by pfeldman

Modified:
6 years, 8 months ago

Reviewers:
kaliamoorthi, pastarmovj

CC:
chromium-reviews, Andrew T Wilson (Slow)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of Refactorise the policy_path_parser framework (https://codereview.chromium.org/214233003/) Reason for revert: Speculative revert due to perf regression: http://build.chromium.org/p/chromium/buildstatus?builder=Linux&number=48755 Original issue's description: > Refactorise the policy_path_parser framework > > This CL performs a refactorisation of the policy path parser framework. > > BUG=352627 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261370 TBR=pastarmovj@chromium.org,kaliamoorthi@chromium.org NOTREECHECKS=true NOTRY=true BUG=352627 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261379

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -305 lines)			Patch
M	chrome/browser/policy/policy_path_parser.h	View	1 chunk	+0 lines, -19 lines	0 comments	Download
D	chrome/browser/policy/policy_path_parser.cc	View	1 chunk	+0 lines, -67 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_linux.cc	View	1 chunk	+34 lines, -30 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_mac.mm	View	2 chunks	+66 lines, -59 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_unittest.cc	View	2 chunks	+7 lines, -43 lines	0 comments	Download
M	chrome/browser/policy/policy_path_parser_win.cc	View	3 chunks	+84 lines, -86 lines	0 comments	Download
M	chrome/policy.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

pfeldman

Created Revert of Refactorise the policy_path_parser framework

6 years, 8 months ago (2014-04-03 14:35:39 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/223993002/1

6 years, 8 months ago (2014-04-03 14:35:51 UTC) #2

Message was sent while issue was closed.

Change committed as 261379