Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: cc/playback/display_item_list_unittest.cc

Issue 2239913002: Allow filters to specify their initial visual rect. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/display_item_list_unittest.cc
diff --git a/cc/playback/display_item_list_unittest.cc b/cc/playback/display_item_list_unittest.cc
index 67d96b4a6dd3eb5c52b4ef7cf07834e3090c916d..0b04b41a48aae7261d6ab4337936231aa9537e5e 100644
--- a/cc/playback/display_item_list_unittest.cc
+++ b/cc/playback/display_item_list_unittest.cc
@@ -943,4 +943,43 @@ TEST(DisplayItemListTest,
EXPECT_RECT_EQ(merged_drawing_bounds, list->VisualRectForTesting(5));
}
+TEST(DisplayItemListTest, AppendVisualRectOneFilterNoDrawings) {
+ scoped_refptr<DisplayItemList> list = CreateDefaultList();
+
+ // One filter containing no drawings: Bf, Ef
+
+ gfx::Rect filter_bounds(5, 6, 1, 1);
+ list->CreateAndAppendPairedBeginItemWithVisualRect<FilterDisplayItem>(
+ filter_bounds, FilterOperations(), gfx::RectF(filter_bounds));
+
+ list->CreateAndAppendPairedEndItem<EndFilterDisplayItem>();
+
+ EXPECT_EQ(2u, list->size());
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(0));
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(1));
+}
+
+TEST(DisplayItemListTest, AppendVisualRectBlockContainingFilterNoDrawings) {
+ scoped_refptr<DisplayItemList> list = CreateDefaultList();
+
+ // One block containing one filter and no drawings: B1, Bf, Ef, E1.
+
+ gfx::Rect clip_bounds(5, 6, 7, 8);
+ list->CreateAndAppendPairedBeginItem<ClipDisplayItem>(
+ clip_bounds, std::vector<SkRRect>(), true);
+
+ gfx::Rect filter_bounds(5, 6, 1, 1);
+ list->CreateAndAppendPairedBeginItemWithVisualRect<FilterDisplayItem>(
+ filter_bounds, FilterOperations(), gfx::RectF(filter_bounds));
+
+ list->CreateAndAppendPairedEndItem<EndFilterDisplayItem>();
+ list->CreateAndAppendPairedEndItem<EndClipDisplayItem>();
+
+ EXPECT_EQ(4u, list->size());
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(0));
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(1));
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(2));
+ EXPECT_RECT_EQ(filter_bounds, list->VisualRectForTesting(3));
+}
+
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698