Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2239903002: VM: Fix math intrinsic code. (Closed)

Created:
4 years, 4 months ago by Florian Schneider
Modified:
4 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix math intrinsic code. The functions where we have intrinsics were always inlined, so the intrinsic code was actually not used. Move these functions to the inline black list instead to ensure the intrinsic code is used instead. Inlining these in the generic inliner would not help anyway since they are inlined as recognized methods by the optimizer. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/f26b130de953bfd69c0e13dc2a0043c1ee7e161d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M runtime/vm/method_recognizer.h View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 4 months ago (2016-08-11 22:03:58 UTC) #2
rmacnak
lgtm
4 years, 4 months ago (2016-08-11 22:15:48 UTC) #3
Florian Schneider
4 years, 4 months ago (2016-08-11 22:49:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f26b130de953bfd69c0e13dc2a0043c1ee7e161d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698