Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2239883002: cc: Remove area calculation overflow in PictureLayerImpl::AppendQuads. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove area calculation overflow in PictureLayerImpl::AppendQuads. This patch ensures that we don't overflow integer bounds when calculating area for various reporting. Note that the types in which the value is stored is already int64_t; it's just a matter of ensuring the temporary calculation on the rhs also uses 64 bit ints. R=danakj, enne BUG=634824 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1127cbf181298f0eadfe8d7582a6b0a97c6922a8 Cr-Commit-Position: refs/heads/master@{#411457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M cc/layers/picture_layer_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-08-11 21:47:19 UTC) #2
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-11 22:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239883002/1
4 years, 4 months ago (2016-08-11 22:42:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 23:59:04 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 00:01:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1127cbf181298f0eadfe8d7582a6b0a97c6922a8
Cr-Commit-Position: refs/heads/master@{#411457}

Powered by Google App Engine
This is Rietveld 408576698