keycodes: Fix non-X11 build when use_xkbcommon=1

keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from ../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from ../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such file or directory

BUG=none

Committed: https://crrev.com/441c0f8dbf56c0508189e23937ccafb11e892835
Cr-Commit-Position: refs/heads/master@{#413174}

[jbriance, 2016-08-12 13:55:31]

jbriance@cisco.com changed reviewers:
+ garykac@chromium.org, kylechar@chromium.org, thakis@chromium.org,
wez@chromium.org

[kylechar, 2016-08-12 14:06:28]

lgtm

[jbriance, 2016-08-12 14:16:52]

The CQ bit was checked by jbriance@cisco.com

[commit-bot: I haz the power, 2016-08-12 14:16:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 14:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 14:22:36]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbriance, 2016-08-12 15:36:36]

Description was changed from

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none
==========

to

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none
==========

[jbriance, 2016-08-12 15:36:37]

jbriance@cisco.com changed reviewers:
+ sadrul@chromium.org

[jbriance, 2016-08-12 15:39:35]

I forgot (again) about the OWNERS rule..

  ** Presubmit ERRORS **
  Missing LGTM from an OWNER for these files:
      ui/events/keycodes/BUILD.gn

[sadrul, 2016-08-15 15:09:58]

sadrul@chromium.org changed reviewers:
- sadrul@chromium.org

[sadrul, 2016-08-15 15:09:58]

You have ui/events/keycodes owners in the reviewer list. Removing myself.

[jbriance, 2016-08-16 21:53:09]

jbriance@cisco.com changed reviewers:
- thakis@chromium.org

[jbriance, 2016-08-16 21:53:09]

Removing Nico, ping Wez and garykac.

[Wez, 2016-08-19 00:18:58]

Do we know when this originally got broken (i.e. which CL)?

[kylechar, 2016-08-19 01:28:33]

On 2016/08/19 00:18:58, Wez wrote:
> Do we know when this originally got broken (i.e. which CL)?

I might have broke it with this CL:
https://chromium.googlesource.com/chromium/src/+/9d0b7792b0761d08442dd8c84fb0...

Although it doesn't appear that USE_XKBCOMMON was defined in
//ui/events:events_base before I moved the files to a new build target... so
maybe not.

[Wez, 2016-08-19 01:34:39]

On 2016/08/19 01:28:33, kylechar wrote:
> On 2016/08/19 00:18:58, Wez wrote:
> > Do we know when this originally got broken (i.e. which CL)?
> 
> I might have broke it with this CL:
>
https://chromium.googlesource.com/chromium/src/+/9d0b7792b0761d08442dd8c84fb0...
> 
> Although it doesn't appear that USE_XKBCOMMON was defined in
> //ui/events:events_base before I moved the files to a new build target... so
> maybe not.

Hmmm, that's strange. Not clear from the CL description whether this was a GN or
GYP failure, though.

[Wez, 2016-08-19 01:35:46]

https://codereview.chromium.org/2239833003/diff/1/ui/events/keycodes/events_k...
File ui/events/keycodes/events_keycodes.gyp (right):

https://codereview.chromium.org/2239833003/diff/1/ui/events/keycodes/events_k...
ui/events/keycodes/events_keycodes.gyp:30: ],
GYP builds are no longer supported; no need for this change.

[jbriance, 2016-08-19 09:02:01]

On 2016/08/19 00:18:58, Wez wrote:
> Do we know when this originally got broken (i.e. which CL)?

It has been broken in M51 by
https://chromium.googlesource.com/chromium/src.git/+/171f4656c6d30e637e8aedb4...
We fixed it locally but forgot to contribute the fix at that time.

Then
https://chromium.googlesource.com/chromium/src/+/9d0b7792b0761d08442dd8c84fb0...
moved the problem in M52, so you're right kylechar when you say this change
didn't broke it originally.

[jbriance, 2016-08-19 09:04:36]

https://codereview.chromium.org/2239833003/diff/1/ui/events/keycodes/events_k...
File ui/events/keycodes/events_keycodes.gyp (right):

https://codereview.chromium.org/2239833003/diff/1/ui/events/keycodes/events_k...
ui/events/keycodes/events_keycodes.gyp:30: ],
On 2016/08/19 01:35:45, Wez wrote:
> GYP builds are no longer supported; no need for this change.

Ok, I'll upload a new CL

[garykac, 2016-08-19 14:39:17]

The CQ bit was checked by garykac@chromium.org

[garykac, 2016-08-19 14:39:18]

lgtm

[garykac, 2016-08-19 14:39:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
kylechar@chromium.org
Link to the patchset: https://codereview.chromium.org/2239833003/#ps20001
(title: "Removing events_keycodes.gyp changes")

[commit-bot: I haz the power, 2016-08-19 14:39:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 17:17:06]

Description was changed from

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none
==========

to

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none
==========

[commit-bot: I haz the power, 2016-08-19 17:17:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 17:19:24]

Description was changed from

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none
==========

to

==========
keycodes: Fix non-X11 build when use_xkbcommon=1

Since M51, ui/events/keycodes/xkb_keysym.h follows X11 path, even if
use_xkbcommon=1 is set because USE_XKBCOMMON is not defined, leading
to the following compilation error in this case:

  In file included from
../../ui/events/keycodes/keyboard_code_conversion_xkb.h:12:0,
                   from
../../ui/events/keycodes/keyboard_code_conversion_xkb.cc:5:
  ../../ui/events/keycodes/xkb_keysym.h:19:19: fatal error: X11/X.h: No such
file or directory

BUG=none

Committed: https://crrev.com/441c0f8dbf56c0508189e23937ccafb11e892835
Cr-Commit-Position: refs/heads/master@{#413174}
==========

[commit-bot: I haz the power, 2016-08-19 17:19:25]

Patchset 2 (id:??) landed as
https://crrev.com/441c0f8dbf56c0508189e23937ccafb11e892835
Cr-Commit-Position: refs/heads/master@{#413174}