[deoptimizer] use correct code/bytecode to compute source position.

[deoptimizer] use correct code/bytecode to compute source position.

With --ignition-preserve-bytecode, we don't have the guarantee that
SharedFunctionInfo::abstract_code() returns the code we deopt to.

R=mstarzinger@chromium.org
BUG=v8:5265
Committed: https://crrev.com/3494a3dcbcdd4d4442c781ed96796e0cf4f9c5d1
Cr-Commit-Position: refs/heads/master@{#38614}

[Yang, 2016-08-12 10:00:09]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 10:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 10:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 10:23:35]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-08-12 10:56:49]

LGTM. Thanks!

https://codereview.chromium.org/2239773003/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

https://codereview.chromium.org/2239773003/diff/1/src/deoptimizer.cc#newcode2690
src/deoptimizer.cc:2690: source_position_ =
Deoptimizer::ComputeSourcePositionFromBaselineCode(
nit: Can we add DCHECK(frame_it->kind() == TranslatedFrame::kFunction) into the
else case?

[Yang, 2016-08-12 11:28:15]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-08-12 11:28:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2239773003/#ps20001
(title: "add dcheck")

[commit-bot: I haz the power, 2016-08-12 11:28:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 12:01:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 12:01:58]

Description was changed from

==========
[deoptimizer] use correct code/bytecode to compute source position.

With --ignition-preserve-bytecode, we don't have the guarantee that
SharedFunctionInfo::abstract_code() returns the code we deopt to.

R=mstarzinger@chromium.org
BUG=v8:5265
==========

to

==========
[deoptimizer] use correct code/bytecode to compute source position.

With --ignition-preserve-bytecode, we don't have the guarantee that
SharedFunctionInfo::abstract_code() returns the code we deopt to.

R=mstarzinger@chromium.org
BUG=v8:5265

Committed: https://crrev.com/3494a3dcbcdd4d4442c781ed96796e0cf4f9c5d1
Cr-Commit-Position: refs/heads/master@{#38614}
==========

[commit-bot: I haz the power, 2016-08-12 12:01:59]

Patchset 2 (id:??) landed as
https://crrev.com/3494a3dcbcdd4d4442c781ed96796e0cf4f9c5d1
Cr-Commit-Position: refs/heads/master@{#38614}