ios/web/web_state/web_view_internal_creation_util.mm - Issue 2239773002: Annotates functions returning retained objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/web_view_internal_creation_util.mm

Issue 2239773002: Annotates functions returning retained objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removes functions that are not in headers AND not in ios code. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/web_view_internal_creation_util.mm

diff --git a/ios/web/web_state/web_view_internal_creation_util.mm b/ios/web/web_state/web_view_internal_creation_util.mm

index 4a96aaeb365a154d08b50f7ddc4e8c8ea3ad8938..c44256ff281797e888ba0edc01d492127112c2bb 100644

--- a/ios/web/web_state/web_view_internal_creation_util.mm

+++ b/ios/web/web_state/web_view_internal_creation_util.mm

@@ -32,7 +32,7 @@ void VerifyWKWebViewCreationPreConditions(

WKWebView* CreateWKWebView(CGRect frame,

WKWebViewConfiguration* configuration,

BrowserState* browser_state,

- BOOL use_desktop_user_agent) {

+ BOOL use_desktop_user_agent) NS_RETURNS_RETAINED {

VerifyWKWebViewCreationPreConditions(browser_state, configuration);

GetWebClient()->PreWebViewCreation();

@@ -58,7 +58,7 @@ WKWebView* CreateWKWebView(CGRect frame,

WKWebView* CreateWKWebView(CGRect frame,

WKWebViewConfiguration* configuration,

- BrowserState* browser_state) {

+ BrowserState* browser_state) NS_RETURNS_RETAINED {

BOOL use_desktop_user_agent = NO;

return CreateWKWebView(frame, configuration, browser_state,

use_desktop_user_agent);