Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2239763002: Using proper keep rule in testing proguard config (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using proper keep rule in testing proguard config BUG=619937 Committed: https://crrev.com/9e1133795d7be524bb30dcce462016202248c829 Cr-Commit-Position: refs/heads/master@{#411648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/android/proguard_for_test.flags View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
smaier
very small change, review whenever you get a chance
4 years, 4 months ago (2016-08-11 17:36:04 UTC) #2
Yaron
lgtm
4 years, 4 months ago (2016-08-11 20:29:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239763002/1
4 years, 4 months ago (2016-08-12 13:44:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 14:37:17 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 14:39:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e1133795d7be524bb30dcce462016202248c829
Cr-Commit-Position: refs/heads/master@{#411648}

Powered by Google App Engine
This is Rietveld 408576698