Added a ForceYouTubeRestrict policy and deprecated the old ForceYouTubeSafetyMode policy

chrome/browser/policy/policy_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
 #include <string>
@@ skipping 865 matching lines @@
       policies->Set(key, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                     POLICY_SOURCE_CLOUD, std::move(value), nullptr);
     } else {
       policies->Erase(key);
     }
   }
 
   void ApplySafeSearchPolicy(
       std::unique_ptr<base::FundamentalValue> legacy_safe_search,
       std::unique_ptr<base::FundamentalValue> google_safe_search,
-      std::unique_ptr<base::FundamentalValue> youtube_safety_mode) {
+      std::unique_ptr<base::FundamentalValue> youtube_restrict) {
     PolicyMap policies;
     SetPolicy(&policies, key::kForceSafeSearch, std::move(legacy_safe_search));
     SetPolicy(&policies, key::kForceGoogleSafeSearch,
               std::move(google_safe_search));
-    SetPolicy(&policies, key::kForceYouTubeSafetyMode,
-              std::move(youtube_safety_mode));
+    SetPolicy(&policies, key::kForceYouTubeRestrict,
+              std::move(youtube_restrict));
     UpdateProviderPolicy(policies);
   }
 
   void CheckSafeSearch(bool expect_safe_search) {
     content::WebContents* web_contents =
         browser()->tab_strip_model()->GetActiveWebContents();
     content::TestNavigationObserver observer(web_contents);
     chrome::FocusLocationBar(browser());
     LocationBar* location_bar = browser()->window()->GetLocationBar();
     ui_test_utils::SendToOmniboxAndSubmit(location_bar, "http://google.com/");
@@ skipping 270 matching lines @@
 IN_PROC_BROWSER_TEST_F(PolicyTest, ForceSafeSearch) {
   // Makes the requests fail since all we want to check is that the redirection
   // is done properly.
   MakeRequestFail make_request_fail("google.com");
 
   // Verifies that requests to Google Search engine with the SafeSearch
   // enabled set the safe=active&ssui=on parameters at the end of the query.
   // First check that nothing happens.
   CheckSafeSearch(false);
 
-  // Go over all combinations of (undefined,true,false) for the three policies.
-  for (int i = 0; i < 3 * 3 * 3; i++) {
-    int legacy = i % 3;
-    int google = (i / 3) % 3;
-    int youtube = i / (3 * 3);
+  // Go over all combinations of (undefined,true,false) resp.
+  // (undefined, off, moderate, strict) for the three policies.
+  for (int i = 0; i < 3 * 3 * 4; i++) {
+    int val = i;
+    int legacy  = val % 3; val /= 3;
+    int google  = val % 3; val /= 3;
+    int youtube = val % 4;
 
     // Override the default SafeSearch setting using policies.
+    static_assert(safe_search_util::YOUTUBE_OFF      == 0 &&
+                  safe_search_util::YOUTUBE_MODERATE == 1 &&
+                  safe_search_util::YOUTUBE_STRICT   == 2,
+                  "Adjust 'youtube' to match YTRM enum");
+
     ApplySafeSearchPolicy(
-        legacy == 0 ? nullptr
-                    : base::WrapUnique(new base::FundamentalValue(legacy == 1)),
-        google == 0 ? nullptr
-                    : base::WrapUnique(new base::FundamentalValue(google == 1)),
-        youtube == 0 ? nullptr : base::WrapUnique(
-                                     new base::FundamentalValue(youtube == 1)));
+       legacy == 0 ? nullptr
+                   : base::WrapUnique(new base::FundamentalValue(legacy == 1)),
+       google == 0 ? nullptr
+                   : base::WrapUnique(new base::FundamentalValue(google == 1)),
+      youtube == 0 ? nullptr            // subtracting 1 gives 0,1,2, see above

[Marc Treib, 2016/09/05 09:58:10]

misaligned

[ljusten (tachyonic), 2016/09/05 15:24:32]

Done.

+                   : base::WrapUnique(new base::FundamentalValue(youtube - 1)));
 
     // The legacy policy should only have an effect if both google and youtube
     // are undefined.
     bool legacy_in_effect = (google == 0 && youtube == 0 && legacy != 0);
     bool legacy_enabled = legacy_in_effect && legacy == 1;
 
     PrefService* prefs = browser()->profile()->GetPrefs();
     EXPECT_EQ(google != 0 || legacy_in_effect,
               prefs->IsManagedPreference(prefs::kForceGoogleSafeSearch));
     EXPECT_EQ(google == 1 || legacy_enabled,
               prefs->GetBoolean(prefs::kForceGoogleSafeSearch));
 
     EXPECT_EQ(youtube != 0 || legacy_in_effect,
-              prefs->IsManagedPreference(prefs::kForceYouTubeSafetyMode));
-    EXPECT_EQ(youtube == 1 || legacy_enabled,
-              prefs->GetBoolean(prefs::kForceYouTubeSafetyMode));
+              prefs->IsManagedPreference(prefs::kForceYouTubeRestrict));
+    EXPECT_EQ(youtube != 0,
+              prefs->GetInteger(prefs::kForceYouTubeRestrict) == youtube - 1);
+
+    // The legacy safe search policy should result in Moderate strictness
+    if (youtube == 0 && legacy_enabled)

[Marc Treib, 2016/09/05 09:58:10]

nit: braces

[ljusten (tachyonic), 2016/09/05 15:24:32]

Done.

+      EXPECT_EQ(prefs->GetInteger(prefs::kForceYouTubeRestrict),
+                safe_search_util::YOUTUBE_MODERATE);
 
     CheckSafeSearch(google == 1 || legacy_enabled);
   }
 }
 
 IN_PROC_BROWSER_TEST_F(PolicyTest, Disable3DAPIs) {
   // This test assumes Gpu access.
   if (!content::GpuDataManager::GetInstance()->GpuAccessAllowed(NULL))
     return;
 
@@ skipping 3163 matching lines @@
 
   SetEmptyPolicy();
   // Policy not set.
   CheckSystemTimezoneAutomaticDetectionPolicyUnset();
   EXPECT_TRUE(CheckResolveTimezoneByGeolocation(true, false));
   EXPECT_TRUE(manager->TimeZoneResolverShouldBeRunningForTests());
 }
 #endif  // defined(OS_CHROMEOS)
 
 }  // namespace policy