Palette tool laser prototype.

ash/common/system/chromeos/palette/tools/laser_pointer_unittest.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/common/system/chromeos/palette/tools/laser_pointer_mode.h"
+#include "ash/common/system/chromeos/palette/tools/laser_pointer_testapis.h"
+#include "ash/common/system/chromeos/palette/tools/laser_pointer_view.h"
+#include "ash/common/wm_shell.h"
+#include "ash/test/ash_test_base.h"
+#include "ui/events/test/event_generator.h"
+
+namespace ash {
+namespace {
+
+const int kTestPointsLifetimeSeconds = 5;
+
+class LaserPointerPointsTest : public test::AshTestBase {
+ public:
+  LaserPointerPointsTest() {}
+  ~LaserPointerPointsTest() override {}
+
+  void SetUp() override {
+    AshTestBase::SetUp();
+    points_.reset(new LaserPointerPoints(
+        base::TimeDelta::FromSeconds(kTestPointsLifetimeSeconds)));
+    points_test_api_.reset(new LaserPointerPointsTestApi(
+        base::WrapUnique<LaserPointerPoints>(new LaserPointerPoints(
+            base::TimeDelta::FromSeconds(kTestPointsLifetimeSeconds)))));
+  }
+
+  void TearDown() override { AshTestBase::TearDown(); }
+
+ protected:
+  std::unique_ptr<LaserPointerPoints> points_;
+  std::unique_ptr<LaserPointerPointsTestApi> points_test_api_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(LaserPointerPointsTest);
+};
+
+class LaserPointerModeTest : public test::AshTestBase {
+ public:
+  LaserPointerModeTest() {}
+  ~LaserPointerModeTest() override {}
+
+  void SetUp() override {
+    AshTestBase::SetUp();
+    mode_test_api_.reset(new LaserPointerModeTestApi(
+        base::WrapUnique<LaserPointerMode>(new LaserPointerMode(nullptr))));
+  }
+
+  void TearDown() override {
+    // This needs to be called first to remove the pointer watcher otherwise
+    // tear down will complain about there being more than zero pointer watcher
+    // alive.
+    mode_test_api_.reset();
+    AshTestBase::TearDown();
+  }
+
+ protected:
+  std::unique_ptr<LaserPointerModeTestApi> mode_test_api_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(LaserPointerModeTest);
+};
+}  // namespace
+
+// Tests that the laser pointers internal collection handles receiving points
+// and that the functions are returning the expected output.
+TEST_F(LaserPointerPointsTest, LaserPointerInternalCollection) {
+  EXPECT_TRUE(points_->IsEmpty());
+  EXPECT_EQ(gfx::Rect(), points_->GetBoundingBox());
+  gfx::Point left(1, 1);
+  gfx::Point bottom(3, 9);
+  gfx::Point top_right(30, 0);
+  points_->AddPoint(left);
+  EXPECT_EQ(gfx::Rect(1, 1, 0, 0), points_->GetBoundingBox());
+  // Should not expand bounding box.

[jdufault, 2016/08/23 02:11:26]

These assertions should be verified as you go, so I'd recommend adding more
EXPECT_* statements.

[sammiequon, 2016/08/23 19:30:02]

Done.

+  points_->AddPoint(gfx::Point(2, 2));
+  // Should be the new bottom of the bounding box.
+  points_->AddPoint(bottom);
+  // Should be the new top and right of the bounding box.
+  points_->AddPoint(top_right);
+  EXPECT_EQ(4, points_->GetNumberOfPoints());
+  EXPECT_FALSE(points_->IsEmpty());
+  EXPECT_EQ(gfx::Rect(left.x(), top_right.y(), top_right.x() - left.x(),
+                      bottom.y() - top_right.y()),
+            points_->GetBoundingBox());
+  // Points should be sorted in the order they are added.
+  EXPECT_EQ(left, points_->GetOldest().location);
+  EXPECT_EQ(top_right, points_->GetNewest().location);
+
+  // Add a new point which will expand the bounding box.
+  gfx::Point new_left_bottom(0, 40);
+  points_->AddPoint(new_left_bottom);
+  EXPECT_EQ(5, points_->GetNumberOfPoints());
+  EXPECT_EQ(gfx::Rect(new_left_bottom.x(), top_right.y(),
+                      top_right.x() - new_left_bottom.x(),
+                      new_left_bottom.y() - top_right.y()),
+            points_->GetBoundingBox());
+
+  points_->Clear();
+  EXPECT_TRUE(points_->IsEmpty());
+}
+
+// Test the laser pointer points collection to verify that old points are
+// removed.
+TEST_F(LaserPointerPointsTest, LaserPointerInternalCollectionDeletion) {
+  gfx::Point test_point(0, 0);
+  base::Time start_time = base::Time::Now();
+
+  // When a point older than kTestPointsLifetime (5 seconds) is added, it
+  // should get removed.
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(1),
+                                      start_time, test_point);

[jdufault, 2016/08/23 02:11:26]

Every call uses the same two constant parameters; you should remove the
parameters.

[sammiequon, 2016/08/23 19:30:02]

Done.

+  EXPECT_EQ(points_test_api_->get_number_of_points(), 1);
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(1),
+                                      start_time, test_point);
+  EXPECT_EQ(points_test_api_->get_number_of_points(), 2);

[jdufault, 2016/08/23 02:11:26]

I don't think we specify it strictly, but typically Chrome does:

  EXPECT_*(expected, actual)


For example:

  EXPECT_EQ(points_test_api_->GetNumberOfPoints(), 4)

vs

  EXPECT_EQ(4, points_test_api_->GetNumberOfPoints())

[sammiequon, 2016/08/23 19:30:02]

Done.

+  // Verify adding a point 10 seconds later will clear all other points, since
+  // they are older than 5 seconds.
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(10),
+                                      start_time, test_point);
+  EXPECT_EQ(points_test_api_->get_number_of_points(), 1);
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(1),
+                                      start_time, test_point);
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(1),
+                                      start_time, test_point);
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(1),
+                                      start_time, test_point);
+  // Verify adding 3 points one second apart each will add 3 points to the

[jdufault, 2016/08/23 02:11:26]

This comment should go on line 125, before you add the points.

[sammiequon, 2016/08/23 19:30:02]

Done.

+  // collection, since all 4 poitns are younger than 5 seconds.
+  EXPECT_EQ(points_test_api_->get_number_of_points(), 4);
+  // Verify adding 1 point three seconds later will remove 2 points which are

[jdufault, 2016/08/23 02:11:26]

newline before each test "section" (ie, above each comment block where you test
a specific function)

[sammiequon, 2016/08/23 19:30:02]

Done.

+  // older than 5 seconds.
+  points_test_api_->MoveForwardInTime(base::TimeDelta::FromSeconds(3),
+                                      start_time, test_point);
+  EXPECT_EQ(points_test_api_->get_number_of_points(), 3);
+}
+
+// Test to ensure the class responsible for drawing the laser pointer receives
+// points from mouse movements as expected.
+TEST_F(LaserPointerModeTest, LaserPointerRenderer) {
+  // TODO(sammiequon): Update these tests once event generator with stylus
+  // events cl lands.
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(10, 40));
+  EXPECT_EQ(0, mode_test_api_->laser_points().GetNumberOfPoints());
+  mode_test_api_->OnEnable();
+  // Verify enabling the mode will start with a single point at the current

[jdufault, 2016/08/23 02:11:26]

Move comment up a line.

[sammiequon, 2016/08/23 19:30:02]

Done.

+  // location.
+  EXPECT_EQ(1, mode_test_api_->laser_points().GetNumberOfPoints());
+
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(25, 66));
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(91, 38));
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(34, 58));
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(19, 71));
+
+  EXPECT_EQ(5, mode_test_api_->laser_points().GetNumberOfPoints());
+
+  mode_test_api_->OnDisable();
+  // Verify disabling the mode will clear any active points.

[jdufault, 2016/08/23 02:11:26]

Move comment up a line

[sammiequon, 2016/08/23 19:30:02]

Done.

+  EXPECT_EQ(0, mode_test_api_->laser_points().GetNumberOfPoints());
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(34, 58));
+  GetEventGenerator().MoveMouseToInHost(gfx::Point(19, 71));
+  // Verify that the laser pointer does not add points while disabled.

[jdufault, 2016/08/23 02:11:26]

Move comment up two lines, add a newline before it.

[sammiequon, 2016/08/23 19:30:02]

Done.

+  EXPECT_EQ(0, mode_test_api_->laser_points().GetNumberOfPoints());
+
+  mode_test_api_->OnEnable();
+  EXPECT_EQ(1, mode_test_api_->laser_points().GetNumberOfPoints());
+  EXPECT_EQ(GetEventGenerator().current_location(),
+            mode_test_api_->laser_points().GetNewest().location);
+}
+}  // namespace ash