Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2239733002:
[heap] Enable black allocation when finalizing incremental marking. (Closed)
|
Created:
4 years, 4 months ago by Hannes Payer (out of office) Modified:
4 years, 3 months ago Reviewers:
Michael Lippautz CC:
v8-reviews_googlegroups.com, Michael Hablich Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[heap] Enable black allocation when finalizing incremental marking.
BUG=chromium:630386
Committed: https://crrev.com/1ccc742dc326b063999670421e1da0ea124874c0
Cr-Commit-Position: refs/heads/master@{#39382}
Patch Set 1 #Patch Set 2 : [heap] Enable black allocation when finalizing incremental marking. #Patch Set 3 : [heap] Enable black allocation when finalizing incremental marking. #Patch Set 4 : [heap] Enable black allocation when finalizing incremental marking. #Patch Set 5 : [heap] Enable black allocation when finalizing incremental marking. #Patch Set 6 : [heap] Enable black allocation when finalizing incremental marking. #Messages
Total messages: 40 (28 generated)
mlippautz@chromium.org changed reviewers: + mlippautz@chromium.org
lgtm
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/6920) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/7020) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11205) v8_linux64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...)
The CQ bit was checked by hpayer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hpayer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlippautz@chromium.org Link to the patchset: https://codereview.chromium.org/2239733002/#ps100001 (title: "[heap] Enable black allocation when finalizing incremental marking.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12521) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by hpayer@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== [heap] Enable black allocation when finalizing incremental marking. BUG=chromium:630386 ========== to ========== [heap] Enable black allocation when finalizing incremental marking. BUG=chromium:630386 Committed: https://crrev.com/1ccc742dc326b063999670421e1da0ea124874c0 Cr-Commit-Position: refs/heads/master@{#39382} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/1ccc742dc326b063999670421e1da0ea124874c0 Cr-Commit-Position: refs/heads/master@{#39382}
Message was sent while issue was closed.
Might lead to: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%... ?
Message was sent while issue was closed.
On 2016/09/13 13:56:52, machenbach (slow) wrote: > Might lead to: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%... > ? or two commits earlier. just guessing...
Message was sent while issue was closed.
On 2016/09/13 13:57:43, machenbach (slow) wrote: > On 2016/09/13 13:56:52, machenbach (slow) wrote: > > Might lead to: > > > https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%... > > ? > > or two commits earlier. just guessing... Though - auto-bisect seems to point to this - but it's a bit flaky...
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/2340463005/ by hablich@chromium.org. The reason for reverting is: Suspecting this is a roll blocker: https://codereview.chromium.org/2332343002/ # # Fatal error in ../../v8/src/heap/spaces.h, line 1618 # Check failed: capacity_ >= bytes (25429824 vs. 18446744073709551168). #. |
