Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 223973002: Add some missing semi-colons in embedded JavaScript. (Closed)

Created:
6 years, 8 months ago by Daniel Bratell
Modified:
6 years, 8 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add some missing semi-colons in embedded JavaScript. Some embedded JavaScript depended on ecmascript's automatic magic semi-colon insertion. That is bad since that means that whitespace becomes significant in the program and prevents stripping of new-lines. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/web/resources/calendarPicker.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/resources/pickerCommon.js View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/resources/suggestionPicker.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Daniel Bratell
Hi, This is just a small cleanup patch I made as part of work on ...
6 years, 8 months ago (2014-04-03 14:30:32 UTC) #1
tkent
lgtm
6 years, 8 months ago (2014-04-04 00:47:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/223973002/1
6 years, 8 months ago (2014-04-04 00:47:49 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 01:19:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-04 01:19:44 UTC) #5
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-04 01:24:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/223973002/1
6 years, 8 months ago (2014-04-04 01:24:20 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-04 01:55:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-04 01:55:15 UTC) #9
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 8 months ago (2014-04-04 01:57:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/223973002/1
6 years, 8 months ago (2014-04-04 01:57:31 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 04:55:39 UTC) #12
Message was sent while issue was closed.
Change committed as 170824

Powered by Google App Engine
This is Rietveld 408576698