Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Issue 2239723002: fix memory leak, remake Imageshader to use sk_sp (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix memory leak, remake Imageshader to use sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239723002 Committed: https://skia.googlesource.com/skia/+/6b2d7acecdd1a1e2b94d6c3b46697c8e9df3dbe5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M src/image/SkImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImageShader.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/image/SkImageShader.cpp View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
reed1
4 years, 4 months ago (2016-08-11 13:20:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2239723002/1
4 years, 4 months ago (2016-08-11 13:20:54 UTC) #5
hal.canary
lgtm
4 years, 4 months ago (2016-08-11 13:23:55 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 13:42:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6b2d7acecdd1a1e2b94d6c3b46697c8e9df3dbe5

Powered by Google App Engine
This is Rietveld 408576698