Refactoring cfx_fontmapper

Clean up cfx_fontmapper a little

Added methods to reduce duplicated code
Nit fixes

Committed: https://pdfium.googlesource.com/pdfium/+/445a94b089c155f79cc8602c724418898dc2a861

[npm, 2016-08-11 17:05:39]

Description was changed from

==========
Refactoring cfx_fontmapper


Refactoring cfx_fontmapper

BUG=
==========

to

==========
Clean up cfx_fontmapper a little

Added methods to reduce duplicated code
Nit fixes
==========

[npm, 2016-08-11 17:05:39]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-08-11 17:06:22]

PTAL

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
File core/fxge/ge/cfx_fontmapper.cpp (left):

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:490: family = g_Base14FontNames[iBaseFont];
If the if loop is entered, this is already the case.

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:855: if (pFontData) {
This if is not needed: FX_ALLOC never returns nullptr

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:868: if (!pFontData) {
Ditto

[dsinclair, 2016-08-11 19:09:12]

lgtm w/ nit.

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
File core/fxge/ge/cfx_fontmapper.cpp (right):

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:631: void* hFont = m_pFontInfo->MapFont(weight,
bItalic, Charset, PitchFamily,
Is this void* because it's platform dependent?

https://codereview.chromium.org/2239703003/diff/1/core/fxge/include/cfx_fontm...
File core/fxge/include/cfx_fontmapper.h (right):

https://codereview.chromium.org/2239703003/diff/1/core/fxge/include/cfx_fontm...
core/fxge/include/cfx_fontmapper.h:62: 
nit: no blank line.

[npm, 2016-08-11 19:17:29]

The CQ bit was checked by npm@chromium.org

[npm, 2016-08-11 19:17:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2239703003/#ps20001
(title: "Nit")

[commit-bot: I haz the power, 2016-08-11 19:17:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-08-11 19:24:11]

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
File core/fxge/ge/cfx_fontmapper.cpp (right):

https://codereview.chromium.org/2239703003/diff/1/core/fxge/ge/cfx_fontmapper...
core/fxge/ge/cfx_fontmapper.cpp:631: void* hFont = m_pFontInfo->MapFont(weight,
bItalic, Charset, PitchFamily,
On 2016/08/11 19:09:12, dsinclair wrote:
> Is this void* because it's platform dependent?

Yes, what this returns depends on what IFX_SystemFontInfo is being used.

https://codereview.chromium.org/2239703003/diff/1/core/fxge/include/cfx_fontm...
File core/fxge/include/cfx_fontmapper.h (right):

https://codereview.chromium.org/2239703003/diff/1/core/fxge/include/cfx_fontm...
core/fxge/include/cfx_fontmapper.h:62: 
On 2016/08/11 19:09:12, dsinclair wrote:
> nit: no blank line.

Done.

[commit-bot: I haz the power, 2016-08-11 19:32:29]

Description was changed from

==========
Clean up cfx_fontmapper a little

Added methods to reduce duplicated code
Nit fixes
==========

to

==========
Clean up cfx_fontmapper a little

Added methods to reduce duplicated code
Nit fixes

Committed:
https://pdfium.googlesource.com/pdfium/+/445a94b089c155f79cc8602c724418898dc2...
==========

[commit-bot: I haz the power, 2016-08-11 19:32:30]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/445a94b089c155f79cc8602c724418898dc2...