Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: test/mjsunit/compiler/inlined-array-pop-opt.js

Issue 2239703002: [turbofan] Add inlined Array.prototype.pop support. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Only convert hole to undefined for holey elements Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/compiler/inlined-array-pop-opt.js
diff --git a/test/mjsunit/compiler/inlined-array-pop-opt.js b/test/mjsunit/compiler/inlined-array-pop-opt.js
new file mode 100644
index 0000000000000000000000000000000000000000..c1301489e7a17e4deae5542ef17b109b58154865
--- /dev/null
+++ b/test/mjsunit/compiler/inlined-array-pop-opt.js
@@ -0,0 +1,83 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+(function() {
+ function foo(a) { return a.pop(); }
+
+ var x = {};
+ var a = [x,x,];
+
+ assertEquals(x, foo(a));
+ assertEquals(x, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(undefined, foo(a));
+ assertOptimized(foo);
+})();
+
+(function() {
+ function foo(a) { return a.pop(); }
+
+ var x = 0;
+ var a = [x,x,];
+
+ assertEquals(x, foo(a));
+ assertEquals(x, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(undefined, foo(a));
+ assertOptimized(foo);
+})();
+
+(function() {
+ function foo(a) { return a.pop(); }
+
+ var x = 0;
+ var a = [x,x,x];
+
+ assertEquals(x, foo(a));
+ assertEquals(x, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(x, foo(a));
+ assertOptimized(foo);
+})();
+
+(function() {
+ function foo(a) { return a.pop(); }
+
+ var x = {};
+ var a = [x,x,x];
+
+ assertEquals(x, foo(a));
+ assertEquals(x, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(x, foo(a));
+ assertOptimized(foo);
+})();
+
+(function() {
+ function foo(a) { return a.pop(); }
+
+ var a = [,,];
+
+ assertEquals(undefined, foo(a));
+ assertEquals(undefined, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(undefined, foo(a));
+ assertOptimized(foo);
+})();
+
+(function() {
+ var pop = Array.prototype.pop;
+
+ function foo(a) { return a.pop(); }
+
+ var a = [1, 2, 3];
+
+ assertEquals(3, foo(a));
+ assertEquals(2, foo(a));
+ %OptimizeFunctionOnNextCall(foo);
+ assertEquals(1, foo(a));
+ assertOptimized(foo);
+})();
« no previous file with comments | « test/mjsunit/compiler/inlined-array-pop-getter2.js ('k') | test/unittests/compiler/js-builtin-reducer-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698